Merge pull request #302 from Libvisual/cmake-check-unparsed-args

Core, Plugins (Build): Check for unparsed arguments when using cmake_parse_arguments().

Author: kaixiong

libvisual-plugins/cmake/LVBuildPlugin.cmake

@@ -14,6 +14,10 @@ FUNCTION(LV_BUILD_PLUGIN PLUGIN_NAME PLUGIN_TYPE)
   SET(MULTI_ARGS "SOURCES" "COMPILE_DEFS" "COMPILE_OPTIONS" "INCLUDE_DIRS" "LINK_DIRS" "LINK_LIBS" "LINK_OPTIONS")
   CMAKE_PARSE_ARGUMENTS(PARSED_ARGS "${OPTION_FLAGS}" "${SINGLE_ARGS}" "${MULTI_ARGS}" ${ARGN})
 
+  IF(PARSED_ARGS_UNPARSED_ARGUMENTS)
+    MESSAGE(FATAL_ERROR "Cannot build plugin '${PLUGIN_NAME}', bad arguments: ${PARSED_ARGS_UNPARSED_ARGUMENTS}")
+  ENDIF()
+
   IF(NOT PARSED_ARGS_SOURCES)
     MESSAGE(FATAL_ERROR "Cannot build plugin '${PLUGIN_NAME}', no source files specified.")
   ENDIF()

libvisual/cmake/LVBuild.cmake

@@ -5,6 +5,10 @@ INCLUDE(CMakeParseArguments)
 FUNCTION(LV_GENERATE_ORC_INLINE_SOURCE SOURCE TARGET)
   CMAKE_PARSE_ARGUMENTS(PARSED_ARGS "HEADER" "INIT_FUNCTION" "INCLUDES" ${ARGN})
 
+  IF(PARSED_ARGS_UNPARSED_ARGUMENTS)
+    MESSAGE(FATAL_ERROR "Cannot generate Orc function(s), bad arguments: ${PARSED_ARGS_UNPARSED_ARGUMENTS}")
+  ENDIF()
+
   SET(ORCC_FLAGS "--inline")
 
   IF(PARSED_ARGS_HEADER)

libvisual/cmake/LVBuildTest.cmake

@@ -6,6 +6,10 @@ FUNCTION(LV_BUILD_TEST TEST_NAME)
   SET(MULTI_ARGS  "ARGS" "SOURCES" "COMPILE_DEFS" "COMPILE_OPTIONS" "INCLUDE_DIRS" "LINK_DIRS" "LINK_LIBS" "LINK_OPTIONS")
   CMAKE_PARSE_ARGUMENTS(PARSED_ARGS "${OPTION_FLAGS}" "${SINGLE_ARGS}" "${MULTI_ARGS}" ${ARGN})
 
+  IF(PARSED_ARGS_UNPARSED_ARGUMENTS)
+    MESSAGE(FATAL_ERROR "Cannot build unit test '${TEST_NAME}', bad arguments: ${PARSED_ARGS_UNPARSED_ARGUMENTS}")
+  ENDIF()
+
   IF(NOT PARSED_ARGS_SOURCES)
     MESSAGE(FATAL_ERROR "Cannot build unit test '${TEST_NAME}', no source files specified.")
   ENDIF()