Plugins (jess): Fix buffer overflow (method fusee, file draw.c)

hartwork · hartwork · commit 2b265c16e218 · 2022-11-30T18:24:02.000+01:00
This is from https://github.com/Pardus-Linux/Packages/blob/master/multimedia/plugin/libvisual-plugins/files/libvisual-plugins-buffer-overflow.patch The related declarations are: > plugins/actor/JESS/jess.h:78: int xi[FUSEE_MAX]; > plugins/actor/JESS/jess.h:80: float life[FUSEE_MAX];
diff --git a/libvisual-plugins/plugins/actor/JESS/draw.c b/libvisual-plugins/plugins/actor/JESS/draw.c
@@ -69,7 +69,7 @@ void fusee(JessPrivate *priv, uint8_t * buffer, int new)
 		while (priv->life[i] > 0)
 		{
 			i++;
-			if (i == FUSEE_MAX+1)
+			if (i == FUSEE_MAX)
 				return;
 		}
 		priv->xi[i] = visual_random_context_int(priv->rcontext) % priv->resx - priv->xres2;

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ void fusee(JessPrivate priv, uint8_t buffer, int new)`
`69`	`69`	`while (priv->life[i] > 0)`
`70`	`70`	`{`
`71`	`71`	`i++;`
`72`		`- if (i == FUSEE_MAX+1)`
	`72`	`+ if (i == FUSEE_MAX)`
`73`	`73`	`return;`
`74`	`74`	`}`
`75`	`75`	`priv->xi[i] = visual_random_context_int(priv->rcontext) % priv->resx - priv->xres2;`