Merge pull request #286 from Libvisual/fix-lv-compile-link-options

Core (Build): Fix LV .so compile and link options.

Author: kaixiong

libvisual-plugins/CMakeLists.txt

@@ -77,6 +77,9 @@ CHECK_FUNCTION_EXISTS(mremap HAVE_MREMAP)
 # Assembly
 #AM_PROG_AS
 
+# Resolve all external symbols when linking SOs.
+OPTION(ENABLE_SO_UNRESOLVED_SYMBOL_CHECKS "Enable resolution of external symbols when linking SOs" yes)
+
 # Internationalization
 SET(GETTEXT_PACKAGE "libvisual-plugins-${LV_PLUGINS_VERSION_SUFFIX}")
 OPTION(ENABLE_NLS "Enable internationalization" yes)

libvisual-plugins/cmake/LVBuildPlugin.cmake

@@ -52,9 +52,12 @@ FUNCTION(LV_BUILD_PLUGIN PLUGIN_NAME PLUGIN_TYPE)
     ${PARSE_ARGS_LINK_OPTIONS}
   )
 
-  SET_TARGET_PROPERTIES(${SO_NAME} PROPERTIES
-    LINK_FLAGS -Wl,--unresolved-symbols,ignore-in-shared-libs
-  )
+  IF(ENABLE_SO_UNRESOLVED_SYMBOL_CHECKS)
+    TARGET_LINK_OPTIONS(${SO_NAME}
+      PRIVATE
+      -Wl,--unresolved-symbols,ignore-in-shared-libs
+    )
+  ENDIF()
 
   TARGET_LINK_LIBRARIES(${SO_NAME}
     PRIVATE

libvisual/CMakeLists.txt

@@ -134,6 +134,9 @@ IF(IS_SYSTEM_DIR STREQUAL "-1")
   SET(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_FULL_LIBDIR}")
 ENDIF()
 
+# Resolve all external symbols when linking SOs.
+OPTION(ENABLE_SO_UNRESOLVED_SYMBOL_CHECKS "Enable resolution of external symbols when linking SOs" yes)
+
 # Compiler optimizations
 OPTION(ENABLE_EXTRA_OPTIMIZATIONS "Enable extra optimizations" no)
 IF(ENABLE_EXTRA_OPTIMIZATIONS)

libvisual/libvisual/CMakeLists.txt

@@ -146,10 +146,10 @@ SET_TARGET_PROPERTIES(libvisual
   OUTPUT_NAME visual-${LV_VERSION_SUFFIX}
   VERSION 0.0.0
   SOVERSION 0
-  COMPILE_OPTIONS -fvisibility=hidden
-  LINK_FLAGS -Wl,--no-undefined
 )
 
+TARGET_COMPILE_OPTIONS(libvisual PRIVATE -fvisibility=hidden)
+
 IF(ENABLE_TESTS)
   TARGET_COMPILE_DEFINITIONS(libvisual PRIVATE _LV_BUILD_PRIVATE_TEST_FUNCS)
 ENDIF()
@@ -163,6 +163,10 @@ TARGET_INCLUDE_DIRECTORIES(libvisual
   ${CMAKE_CURRENT_BINARY_DIR}
 )
 
+IF(ENABLE_SO_UNRESOLVED_SYMBOL_CHECKS)
+  TARGET_LINK_OPTIONS(libvisual PRIVATE -Wl,--no-undefined)
+ENDIF()
+
 TARGET_LINK_LIBRARIES(libvisual
   PRIVATE
   PkgConfig::ORC