Core (Build): Use a different flag to enable building of functions within Core for unit testing only.

Author: kaixiong

libvisual/cmake/LVBuildTest.cmake

@@ -12,6 +12,8 @@ FUNCTION(LV_BUILD_TEST TEST_NAME)
 
   ADD_EXECUTABLE(${TEST_NAME} ${PARSED_ARGS_SOURCES})
 
+  TARGET_COMPILE_DEFINITIONS(${TEST_NAME} PRIVATE _LV_BUILD_PRIVATE_TEST_FUNCS)
+
   IF(${PARSED_ARGS_COMPILE_DEFS})
     TARGET_COMPILE_DEFINITIONS(${TEST_NAME} PRIVATE ${PARSED_ARGS_COMPILE_DEFS})
   ENDIF()

libvisual/libvisual/CMakeLists.txt

@@ -150,6 +150,10 @@ SET_TARGET_PROPERTIES(libvisual
   LINK_FLAGS -Wl,--no-undefined
 )
 
+IF(ENABLE_TESTS)
+  TARGET_COMPILE_DEFINITIONS(libvisual PRIVATE _LV_BUILD_PRIVATE_TEST_FUNCS)
+ENDIF()
+
 TARGET_INCLUDE_DIRECTORIES(libvisual
   PRIVATE
   ${PROJECT_SOURCE_DIR}

libvisual/libvisual/lv_video.cpp

@@ -293,7 +293,7 @@ namespace LV {
       return true;
   }
 
-  #ifdef LV_ENABLE_TESTS
+#ifdef _LV_BUILD_PRIVATE_TEST_FUNCS
   bool Video::validate() const
   {
       // Validate dimensions.
@@ -360,7 +360,7 @@ namespace LV {
 
       return true;
   }
-  #endif // defined(LV_ENABLE_TESTS)
+#endif // defined(_LV_BUILD_PRIVATE_TEST_FUNCS)
 
   bool Video::has_same_content (VideoConstPtr const& video) const
   {

libvisual/libvisual/lv_video.h

@@ -294,7 +294,7 @@ namespace LV {
        */
       bool compare_attrs_ignore_pitch (VideoConstPtr const& src) const;
 
-#ifdef LV_ENABLE_TESTS
+#ifdef _LV_BUILD_PRIVATE_TEST_FUNCS
       /**
        * Validates the state of this Video.
        *
@@ -303,7 +303,7 @@ namespace LV {
        * @return true if video has consistent state, false otherwise.
        */
       bool validate() const;
-#endif // defined(LV_ENABLE_TESTS)
+#endif // defined(_LV_BUILD_PRIVATE_TEST_FUNCS)
 
       /**
        * Checks if this Video has the same (pixel) content as another Video.