Core (Memory): Use _mm_set_epi16() for broadcasting the 16-bit value to set.

kaixiong · kaixiong · commit ba5f5b6057b9 · 2023-03-04T20:58:00.000+08:00
diff --git a/libvisual/libvisual/lv_mem.c b/libvisual/libvisual/lv_mem.c
@@ -140,8 +140,7 @@ static void *mem_set16_c (void *dest, int c, visual_size_t n)
 void *mem_set16_x86_sse2 (void *dest, int c, size_t n)
 {
 	const uint16_t copy    = c & 0xffff;
-	const uint32_t copy_2x = copy | (copy << 16);
-	const __m128i  copy_4x = _mm_set_epi32 (copy_2x, copy_2x, copy_2x, copy_2x);
+	const __m128i  copy_4x = _mm_set_epi16 (copy, copy, copy, copy, copy, copy, copy, copy);
 
 	__m128i *m128i_ptr = (__m128i *) dest;
 

Original file line number	Diff line number	Diff line change
`@@ -140,8 +140,7 @@ static void mem_set16_c (void dest, int c, visual_size_t n)`
`140`	`140`	`void mem_set16_x86_sse2 (void dest, int c, size_t n)`
`141`	`141`	`{`
`142`	`142`	`const uint16_t copy = c & 0xffff;`
`143`		`- const uint32_t copy_2x = copy \| (copy << 16);`
`144`		`- const __m128i copy_4x = _mm_set_epi32 (copy_2x, copy_2x, copy_2x, copy_2x);`
	`143`	`+ const __m128i copy_4x = _mm_set_epi16 (copy, copy, copy, copy, copy, copy, copy, copy);`
`145`	`144`
`146`	`145`	`__m128i m128i_ptr = (__m128i ) dest;`
`147`	`146`