Plugins (oinksie): Address Clang warning -Wunsequenced

hartwork · hartwork · commit fb284c3d073a · 2022-12-03T00:38:29.000+01:00
&gt; [..]/plugins/actor/oinksie/gfx-blur.c:64:9: warning: unsequenced modification and access to 'buf' [-Wunsequenced]
&gt;                         *(buf++) = valuetab[*buf];
&gt;                              ^               ~~~
diff --git a/libvisual-plugins/plugins/actor/oinksie/gfx-blur.c b/libvisual-plugins/plugins/actor/oinksie/gfx-blur.c
@@ -60,8 +60,10 @@ void _oink_gfx_blur_fade (OinksiePrivate *priv, uint8_t *buf, int fade)
 		for (i = 0; i < 256; i++)
 			valuetab[i] = (i - fade) > 0 ? i - fade : 0;
 
-		for (i = 0; i < priv->screen_size; i++)
-			*(buf++) = valuetab[*buf];
+		for (i = 0; i < priv->screen_size; i++) {
+			*buf = valuetab[*buf];
+			buf++;
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -60,8 +60,10 @@ void _oink_gfx_blur_fade (OinksiePrivate priv, uint8_t buf, int fade)`
`60`	`60`	`for (i = 0; i < 256; i++)`
`61`	`61`	`valuetab[i] = (i - fade) > 0 ? i - fade : 0;`
`62`	`62`
`63`		`- for (i = 0; i < priv->screen_size; i++)`
`64`		`- (buf++) = valuetab[buf];`
	`63`	`+ for (i = 0; i < priv->screen_size; i++) {`
	`64`	`+ buf = valuetab[buf];`
	`65`	`+ buf++;`
	`66`	`+ }`
`65`	`67`	`}`
`66`	`68`	`}`
`67`	`69`