Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Commit c2f0811

Browse files
committed
2 parents f2aa266 + 6bbb259 commit c2f0811

File tree

18 files changed

+648
-428
lines changed

18 files changed

+648
-428
lines changed

Example/PinpointKitExample.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@
357357
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
358358
INFOPLIST_FILE = PinpointKitExample/Info.plist;
359359
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
360-
MARKETING_VERSION = 1.4.0;
360+
MARKETING_VERSION = 1.5.0;
361361
PRODUCT_BUNDLE_IDENTIFIER = net.Lickability.PinpointKitExample;
362362
PRODUCT_NAME = "$(TARGET_NAME)";
363363
};
@@ -370,7 +370,7 @@
370370
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
371371
INFOPLIST_FILE = PinpointKitExample/Info.plist;
372372
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
373-
MARKETING_VERSION = 1.4.0;
373+
MARKETING_VERSION = 1.5.0;
374374
PRODUCT_BUNDLE_IDENTIFIER = net.Lickability.PinpointKitExample;
375375
PRODUCT_NAME = "$(TARGET_NAME)";
376376
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";

Example/PinpointKitExample/Info.plist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@
3636
<string>UIInterfaceOrientationLandscapeLeft</string>
3737
<string>UIInterfaceOrientationLandscapeRight</string>
3838
</array>
39+
<key>NSPhotoLibraryUsageDescription</key>
40+
<string>The example application accesses your photo library.</string>
3941
<key>UISupportedInterfaceOrientations~ipad</key>
4042
<array>
4143
<string>UIInterfaceOrientationPortrait</string>

Example/Podfile.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PODS:
2-
- PinpointKit (1.4.0):
3-
- PinpointKit/Core (= 1.4.0)
4-
- PinpointKit/Core (1.4.0)
2+
- PinpointKit (1.5.0):
3+
- PinpointKit/Core (= 1.5.0)
4+
- PinpointKit/Core (1.5.0)
55
- SwiftLint (0.25.1)
66

77
DEPENDENCIES:
@@ -17,7 +17,7 @@ EXTERNAL SOURCES:
1717
:path: "../"
1818

1919
SPEC CHECKSUMS:
20-
PinpointKit: a33c929c2e9c3b7d9a1a343fd309161b71c02d06
20+
PinpointKit: a513c4623502581067f3f8b60b9cffef6c8e1025
2121
SwiftLint: ce933681be10c3266e82576dad676fa815a602e9
2222

2323
PODFILE CHECKSUM: 24af8a2ca63352a72ca1cd13fc8977477eae3a12

Example/Pods/Local Podspecs/PinpointKit.podspec.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Example/Pods/Manifest.lock

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Example/Pods/Pods.xcodeproj/project.pbxproj

Lines changed: 381 additions & 377 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Example/Pods/Target Support Files/PinpointKit/Info.plist

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

PinpointKit.podspec.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"name": "PinpointKit",
3-
"version": "1.4.0",
3+
"version": "1.5.0",
44
"homepage": "https://github.com/Lickability/PinpointKit",
55
"source": {
66
"git": "https://github.com/Lickability/PinpointKit.git",
7-
"tag": "1.4.0"
7+
"tag": "1.5.0"
88
},
99
"summary": "A library that makes bug reporting simple for your users by allowing them to send feedback with annotated screenshots and logs.",
1010
"authors" : {

PinpointKit/PinpointKit.xcodeproj/project.pbxproj

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@
7070
DA0DA60D1C53049B0012ADBE /* PinpointKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DA0DA6021C53049B0012ADBE /* PinpointKit.framework */; };
7171
F24381121D54CBAB004CC87F /* SystemLogCollectorTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = F24381111D54CBAB004CC87F /* SystemLogCollectorTests.swift */; };
7272
F24381151D54ECD2004CC87F /* XCTestCaseExpectationExtensions.swift in Sources */ = {isa = PBXBuildFile; fileRef = F24381141D54ECD2004CC87F /* XCTestCaseExpectationExtensions.swift */; };
73+
F2619BA32512C6100083286C /* RequestScreenshotCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = F2619BA22512C6100083286C /* RequestScreenshotCell.swift */; };
7374
/* End PBXBuildFile section */
7475

7576
/* Begin PBXContainerItemProxy section */
@@ -147,6 +148,7 @@
147148
DA0DA6131C53049B0012ADBE /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
148149
F24381111D54CBAB004CC87F /* SystemLogCollectorTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SystemLogCollectorTests.swift; sourceTree = "<group>"; };
149150
F24381141D54ECD2004CC87F /* XCTestCaseExpectationExtensions.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = XCTestCaseExpectationExtensions.swift; sourceTree = "<group>"; };
151+
F2619BA22512C6100083286C /* RequestScreenshotCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = RequestScreenshotCell.swift; path = Core/RequestScreenshotCell.swift; sourceTree = "<group>"; };
150152
/* End PBXFileReference section */
151153

152154
/* Begin PBXFrameworksBuildPhase section */
@@ -206,6 +208,7 @@
206208
4C4037F11D9EB01800305A6E /* FeedbackViewController.swift */,
207209
4C4037EF1D9EB01800305A6E /* FeedbackNavigationController.swift */,
208210
4C4037FC1D9EB04400305A6E /* Screenshotter.swift */,
211+
F2619BA22512C6100083286C /* RequestScreenshotCell.swift */,
209212
4C4037F91D9EB02300305A6E /* ScreenshotCell.swift */,
210213
4C4037EE1D9EB01800305A6E /* FeedbackConfiguration.swift */,
211214
4C4037F01D9EB01800305A6E /* FeedbackTableViewDataSource.swift */,
@@ -490,6 +493,7 @@
490493
4C4038091D9EB0CB00305A6E /* UIView+PinpointKit.swift in Sources */,
491494
4CFB58801E29464B00B64D0D /* EditImageViewControllerBarButtonItemProviding.swift in Sources */,
492495
4C40382C1D9EB7A800305A6E /* ScreenshotDetector.swift in Sources */,
496+
F2619BA32512C6100083286C /* RequestScreenshotCell.swift in Sources */,
493497
4C4038011D9EB07000305A6E /* LogViewer.swift in Sources */,
494498
4C4037FF1D9EB06900305A6E /* BasicLogViewController.swift in Sources */,
495499
4C4037D51D9EAF0D00305A6E /* Editor.swift in Sources */,
@@ -686,7 +690,7 @@
686690
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
687691
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
688692
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
689-
MARKETING_VERSION = 1.4.0;
693+
MARKETING_VERSION = 1.5.0;
690694
PRODUCT_BUNDLE_IDENTIFIER = net.Lickability.PinpointKit;
691695
PRODUCT_NAME = "$(TARGET_NAME)";
692696
SKIP_INSTALL = YES;
@@ -709,7 +713,7 @@
709713
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
710714
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
711715
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
712-
MARKETING_VERSION = 1.4.0;
716+
MARKETING_VERSION = 1.5.0;
713717
PRODUCT_BUNDLE_IDENTIFIER = net.Lickability.PinpointKit;
714718
PRODUCT_NAME = "$(TARGET_NAME)";
715719
SKIP_INSTALL = YES;

PinpointKit/PinpointKit/Sources/Core/FeedbackCollector.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ public protocol FeedbackCollector: class, LogSupporting, InterfaceCustomizable {
2424
/**
2525
Begins feedback collection about a screenshot from a view controller.
2626

27-
- parameter screenshot: The screenshot the user will be providing feedback on.
27+
- parameter screenshot: The screenshot the user will be providing feedback on. If the screenshot is nil, the user will be presented with a button to select a screenshot from their photo library.
2828
- parameter viewController: The view controller from which to present.
2929
*/
30-
func collectFeedback(with screenshot: UIImage, from viewController: UIViewController)
30+
func collectFeedback(with screenshot: UIImage?, from viewController: UIViewController)
3131
}
3232

3333
extension FeedbackCollector where Self: UIViewController {

0 commit comments

Comments
 (0)