Skip to content

Commit 7d060f4

Browse files
authored
Apply suggestions from code review
1 parent 90e3388 commit 7d060f4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/litmodels/integrations/checkpoints.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ def __init__(self, model_name: str, *args: Any, **kwargs: Any) -> None:
5151

5252
def _save_checkpoint(self, trainer: Trainer, filepath: str) -> None:
5353
super()._save_checkpoint(trainer, filepath)
54-
# upload model after checkpoint is saved
54+
# todo: uploading on background so training does nt stops
55+
# todo: use filename as version but need to validate that such version does not exists yet
5556
upload_model(name=self.model_name, model=filepath)
5657

5758
return cast(Type[ModelCheckpointType], LitModelCheckpointTemplate)

0 commit comments

Comments
 (0)