[pre-commit.ci] pre-commit suggestions (#86)

* [pre-commit.ci] pre-commit suggestions

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.5.0...v5.0.0)
- [github.com/codespell-project/codespell: v2.2.6 → v2.4.1](codespell-project/codespell@v2.2.6...v2.4.1)
- [github.com/pre-commit/mirrors-prettier: v3.1.0 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.1.0...v4.0.0-alpha.8)
- [github.com/executablebooks/mdformat: 0.7.17 → 0.7.22](hukkin/mdformat@0.7.17...0.7.22)
- https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit
- [github.com/astral-sh/ruff-pre-commit: v0.3.3 → v0.11.4](astral-sh/ruff-pre-commit@v0.3.3...v0.11.4)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka B <[email protected]>

Author: pre-commit-ci[bot]

.pre-commit-config.yaml

@@ -9,7 +9,7 @@ ci:
 
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.5.0
+    rev: v5.0.0
     hooks:
       - id: end-of-file-fixer
       - id: trailing-whitespace
@@ -28,7 +28,7 @@ repos:
       - id: python-use-type-annotations
 
   - repo: https://github.com/codespell-project/codespell
-    rev: v2.2.6
+    rev: v2.4.1
     hooks:
       - id: codespell
         additional_dependencies: [tomli]
@@ -43,7 +43,7 @@ repos:
         args: ["--print-width=120"]
 
   - repo: https://github.com/executablebooks/mdformat
-    rev: 0.7.17
+    rev: 0.7.22
     hooks:
       - id: mdformat
         args: ["--number"]
@@ -53,8 +53,8 @@ repos:
           - mdformat_frontmatter
         exclude: CHANGELOG.md
 
-  - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.3.3
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.11.4
     hooks:
       - id: ruff
         args: ["--fix"]

examples/demo-upload-download.py

@@ -1,7 +1,8 @@
-import litmodels
 import torch
 from lightning.pytorch.demos.boring_classes import BoringModel
 
+import litmodels
+
 if __name__ == "__main__":
     # Define your model
     model = BoringModel()

examples/resume-lightning-training.py

@@ -6,6 +6,7 @@
 
 from lightning import Trainer
 from lightning.pytorch.demos.boring_classes import BoringModel
+
 from litmodels import download_model
 
 # Define the model name - this should be unique to your model

examples/train-model-and-simple-save.py

@@ -4,6 +4,7 @@
 
 from lightning import Trainer
 from lightning.pytorch.demos.boring_classes import BoringModel
+
 from litmodels import upload_model
 
 # Define the model name - this should be unique to your model

examples/train-model-with-lightning-callback.py

@@ -4,6 +4,7 @@
 
 from lightning import Trainer
 from lightning.pytorch.demos.boring_classes import BoringModel
+
 from litmodels.integrations import LightningModelCheckpoint
 
 # Define the model name - this should be unique to your model

pyproject.toml

@@ -115,8 +115,6 @@ ignore = [
     "E731",  # Do not assign a lambda expression, use a def
     "D100", # Missing docstring in public module
 ]
-# Exclude a variety of commonly ignored directories.
-ignore-init-module-imports = true
 
 [tool.ruff.lint.per-file-ignores]
 "setup.py" = ["D100", "SIM115"]

tests/conftest.py

@@ -1,6 +1,7 @@
 """Pytest configuration for integration tests."""
 
 import pytest
+
 from litmodels.integrations.checkpoints import get_model_manager
 
 

tests/integrations/__init__.py

@@ -1,4 +1,5 @@
 import pytest
+
 from litmodels.integrations.imports import (
     _LIGHTNING_AVAILABLE,
     _LIGHTNING_GREATER_EQUAL_2_5_1,

tests/integrations/test_checkpoints.py

@@ -2,9 +2,9 @@
 import re
 from unittest import mock
 
-import litmodels
 import pytest
 
+import litmodels
 from tests.integrations import _SKIP_IF_LIGHTNING_MISSING, _SKIP_IF_PYTORCHLIGHTNING_MISSING
 
 
@@ -25,13 +25,15 @@ def test_lightning_checkpoint_callback(mock_auth, mock_upload_model, monkeypatch
         from lightning import Trainer
         from lightning.pytorch.callbacks import ModelCheckpoint
         from lightning.pytorch.demos.boring_classes import BoringModel
+
         from litmodels.integrations.checkpoints import LightningModelCheckpoint as LitModelCheckpoint
     elif importing == "pytorch_lightning":
-        from litmodels.integrations.checkpoints import PytorchLightningModelCheckpoint as LitModelCheckpoint
         from pytorch_lightning import Trainer
         from pytorch_lightning.callbacks import ModelCheckpoint
         from pytorch_lightning.demos.boring_classes import BoringModel
 
+        from litmodels.integrations.checkpoints import PytorchLightningModelCheckpoint as LitModelCheckpoint
+
     # Validate inheritance
     assert issubclass(LitModelCheckpoint, ModelCheckpoint)
 

tests/integrations/test_cloud.py

@@ -9,11 +9,11 @@
 from lightning_sdk import Teamspace
 from lightning_sdk.lightning_cloud.rest_client import GridRestClient
 from lightning_sdk.utils.resolve import _resolve_teamspace
+
 from litmodels import download_model, upload_model
 from litmodels.integrations.duplicate import duplicate_hf_model
 from litmodels.integrations.mixins import PickleRegistryMixin, PyTorchRegistryMixin
 from litmodels.io.cloud import _list_available_teamspaces
-
 from tests.integrations import (
     _SKIP_IF_LIGHTNING_BELLOW_2_5_1,
     _SKIP_IF_PYTORCHLIGHTNING_BELLOW_2_5_1,
@@ -44,7 +44,7 @@ def _cleanup_model(teamspace: Teamspace, model_name: str, expected_num_versions:
     client.models_store_delete_model(project_id=model.project_id, model_id=model.id)
 
 
-@pytest.mark.cloud()
+@pytest.mark.cloud
 @pytest.mark.parametrize(
     "in_studio",
     [False, pytest.param(True, marks=pytest.mark.skipif(platform.system() != "Linux", reason="Studio is just Linux"))],
@@ -100,7 +100,7 @@ def test_upload_download_model(in_studio, monkeypatch, tmp_path):
         pytest.param(True, marks=pytest.mark.skipif(platform.system() == "Windows", reason="studio is not Windows")),
     ],
 )
-@pytest.mark.cloud()
+@pytest.mark.cloud
 def test_lightning_default_checkpointing(importing, in_studio, monkeypatch, tmp_path):
     if in_studio:
         # mock env variables as it would run in studio
@@ -140,7 +140,7 @@ def test_lightning_default_checkpointing(importing, in_studio, monkeypatch, tmp_
         pytest.param("pytorch_lightning", marks=_SKIP_IF_PYTORCHLIGHTNING_BELLOW_2_5_1),
     ],
 )
-@pytest.mark.cloud()
+@pytest.mark.cloud
 # todo: mock env variables as it would run in studio
 def test_lightning_plain_resume(trainer_method, registry, importing, tmp_path):
     if importing == "lightning":
@@ -194,7 +194,7 @@ def test_lightning_plain_resume(trainer_method, registry, importing, tmp_path):
         pytest.param("pytorch_lightning", marks=_SKIP_IF_PYTORCHLIGHTNING_BELLOW_2_5_1),
     ],
 )
-@pytest.mark.cloud()
+@pytest.mark.cloud
 def test_lightning_checkpoint_ddp(importing, tmp_path):
     if importing == "lightning":
         from lightning import Trainer
@@ -229,7 +229,7 @@ def __init__(self, value):
         self.value = value
 
 
-@pytest.mark.cloud()
+@pytest.mark.cloud
 def test_pickle_mixin_push_and_pull():
     # model name with random hash
     teamspace, org_team, model_name = _prepare_variables("pickle_mixin")
@@ -263,7 +263,7 @@ def forward(self, x):
         return self.fc(x)
 
 
-@pytest.mark.cloud()
+@pytest.mark.cloud
 def test_pytorch_mixin_push_and_pull():
     # model name with random hash
     teamspace, org_team, model_name = _prepare_variables("torch_mixin")
@@ -289,7 +289,7 @@ def test_pytorch_mixin_push_and_pull():
     _cleanup_model(teamspace, model_name, expected_num_versions=1)
 
 
-@pytest.mark.cloud()
+@pytest.mark.cloud
 def test_duplicate_real_hf_model(tmp_path):
     """Verify that the HF model can be duplicated to the teamspace"""
 
@@ -309,7 +309,7 @@ def test_duplicate_real_hf_model(tmp_path):
     client.models_store_delete_model(project_id=teamspace.id, model_id=model.id)
 
 
-@pytest.mark.cloud()
+@pytest.mark.cloud
 def test_list_available_teamspaces():
     teams = _list_available_teamspaces()
     assert len(teams) > 0