Skip to content

Commit 72655ce

Browse files
authored
fix: ensure proper cleanup of processes in wrap_litserve_start (#432)
1 parent 49cedbd commit 72655ce

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/litserve/utils.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,13 @@ def wrap_litserve_start(server: "LitServer"):
6868
server.lit_spec.response_queue_id = 0
6969
manager, processes = server.launch_inference_worker(num_uvicorn_servers=1)
7070
server._prepare_app_run(server.app)
71-
yield server
72-
for p in processes:
73-
p.terminate()
74-
manager.shutdown()
71+
try:
72+
yield server
73+
finally:
74+
for p in processes:
75+
p.terminate()
76+
p.join()
77+
manager.shutdown()
7578

7679

7780
async def call_after_stream(streamer: AsyncIterator, callback, *args, **kwargs):

0 commit comments

Comments
 (0)