Skip to content

Commit 333bb23

Browse files
Bordat-vi
andauthored
test: flexible wait for serve start (#1996)
Co-authored-by: Thomas Viehmann <[email protected]>
1 parent 45d7ca9 commit 333bb23

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

tests/test_readme.py

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
import pytest
1212
import requests
13+
from urllib3.exceptions import MaxRetryError
1314

1415
from litgpt.utils import _RunIf
1516

@@ -215,14 +216,17 @@ def run_server():
215216
server_thread = threading.Thread(target=run_server)
216217
server_thread.start()
217218

218-
# Allow time to initialize and start serving
219-
time.sleep(30)
220-
221-
try:
222-
response = requests.get("http://127.0.0.1:8000")
223-
print(response.status_code)
224-
assert response.status_code == 200, "Server did not respond as expected."
225-
finally:
226-
if process:
227-
process.kill()
228-
server_thread.join()
219+
for _ in range(30):
220+
try:
221+
response = requests.get("http://127.0.0.1:8000", timeout=1)
222+
response_status_code = response.status_code
223+
except (MaxRetryError, requests.exceptions.ConnectionError):
224+
response_status_code = -1
225+
if response_status_code == 200:
226+
break
227+
time.sleep(1)
228+
assert response_status_code == 200, "Server did not respond as expected."
229+
230+
if process:
231+
process.kill()
232+
server_thread.join()

0 commit comments

Comments
 (0)