From 0229abe029e4c4622419484308cf80b9a1fcb4da Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Tue, 18 Nov 2025 11:58:33 +0545 Subject: [PATCH 1/4] Drop Python 3.9 support - Require Python >=3.10 in pyproject.toml - Remove Python 3.9 classifier - Simplify jsonargparse dependency to target >=3.10 - Update CI matrix to remove 3.9 and move oldest job to 3.10 --- .github/workflows/cpu-tests.yml | 4 ++-- pyproject.toml | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/cpu-tests.yml b/.github/workflows/cpu-tests.yml index fbe8fb21d7..a9ec161c93 100644 --- a/.github/workflows/cpu-tests.yml +++ b/.github/workflows/cpu-tests.yml @@ -79,10 +79,10 @@ jobs: fail-fast: false matrix: os: ["ubuntu-22.04"] - python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] + python-version: ["3.10", "3.11", "3.12", "3.13"] requires: ["latest"] include: - - { os: "ubuntu-22.04", python-version: "3.9", requires: "oldest" } + - { os: "ubuntu-22.04", python-version: "3.10", requires: "oldest" } - { os: "windows-2022", python-version: "3.10", requires: "latest" } - { os: "macOS-14", python-version: "3.10", requires: "latest" } timeout-minutes: 35 diff --git a/pyproject.toml b/pyproject.toml index b4fc2c8cca..6f6e72bcaa 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -16,9 +16,9 @@ license = { file = "LICENSE" } authors = [ { name = "Lightning AI", email = "contact@lightning.ai" }, ] +requires-python = ">=3.10" classifiers = [ "Programming Language :: Python :: 3 :: Only", - "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", "Programming Language :: Python :: 3.12", @@ -27,8 +27,7 @@ classifiers = [ dependencies = [ # download models: "huggingface-hub>=0.30,<0.35", - "jsonargparse[signatures]>=4.31,<=4.32.1; python_version<'3.10'", # 4.33 does not seem to be compatible with Python 3.9 - "jsonargparse[signatures]>=4.37,<=4.41; python_version>'3.9'", # required to work with python3.12+ + "jsonargparse[signatures]>=4.37,<=4.41; python_version>='3.10'", # required to work with Python >=3.10 "lightning>=2.5", "psutil==7", "safetensors>=0.4.3", From 1bdc78f3aa764bd90e368fc6964fe183908fb536 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 19 Nov 2025 06:28:16 +0000 Subject: [PATCH 2/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 6f6e72bcaa..42d9479a58 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -27,7 +27,7 @@ classifiers = [ dependencies = [ # download models: "huggingface-hub>=0.30,<0.35", - "jsonargparse[signatures]>=4.37,<=4.41; python_version>='3.10'", # required to work with Python >=3.10 + "jsonargparse[signatures]>=4.37,<=4.41; python_version>='3.10'", # required to work with Python >=3.10 "lightning>=2.5", "psutil==7", "safetensors>=0.4.3", From 0ddd030ec8b404b636766526625f5fcb8571349b Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Wed, 19 Nov 2025 12:23:43 +0545 Subject: [PATCH 3/4] update --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 42d9479a58..bdfd628314 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -16,7 +16,6 @@ license = { file = "LICENSE" } authors = [ { name = "Lightning AI", email = "contact@lightning.ai" }, ] -requires-python = ">=3.10" classifiers = [ "Programming Language :: Python :: 3 :: Only", "Programming Language :: Python :: 3.10", @@ -27,6 +26,7 @@ classifiers = [ dependencies = [ # download models: "huggingface-hub>=0.30,<0.35", + "jsonargparse[signatures]>=4.31,<=4.32.1; python_version<'3.10'", # 4.33 does not seem to be compatible with Python 3.9 "jsonargparse[signatures]>=4.37,<=4.41; python_version>='3.10'", # required to work with Python >=3.10 "lightning>=2.5", "psutil==7", From b3d84eb251402aba606b76ce163ec0574838402d Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 19 Nov 2025 06:39:19 +0000 Subject: [PATCH 4/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- pyproject.toml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index bdfd628314..9046077ae2 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -18,6 +18,7 @@ authors = [ ] classifiers = [ "Programming Language :: Python :: 3 :: Only", + "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", "Programming Language :: Python :: 3.12", @@ -27,7 +28,7 @@ dependencies = [ # download models: "huggingface-hub>=0.30,<0.35", "jsonargparse[signatures]>=4.31,<=4.32.1; python_version<'3.10'", # 4.33 does not seem to be compatible with Python 3.9 - "jsonargparse[signatures]>=4.37,<=4.41; python_version>='3.10'", # required to work with Python >=3.10 + "jsonargparse[signatures]>=4.37,<=4.41; python_version>='3.10'", # required to work with Python >=3.10 "lightning>=2.5", "psutil==7", "safetensors>=0.4.3",