fix: fix unittests.

Author: GdoongMathew

tests/tests_pytorch/trainer/properties/test_loggers.py

@@ -23,24 +23,21 @@ def test_trainer_loggers_property():
     """Test for correct initialization of loggers in Trainer."""
     logger1 = CustomLogger()
     logger2 = CustomLogger()
-    logger3 = CustomLogger()
+    CustomLogger()
 
     # trainer.loggers should be a copy of the input list
     trainer = Trainer(logger=[logger1, logger2])
 
     assert trainer.loggers == [logger1, logger2]
-    assert trainer.logger_map == {}
 
     # trainer.loggers should create a list of size 1
     trainer = Trainer(logger=logger1)
 
     assert trainer.logger == logger1
     assert trainer.loggers == [logger1]
-    assert trainer.logger_map == {}
 
     trainer.loggers.append(logger2)
     assert trainer.loggers == [logger1, logger2]
-    assert trainer.logger_map == {}
 
     # trainer.loggers should be a list of size 1 holding the default logger
     trainer = Trainer(logger=True)
@@ -51,19 +48,15 @@ def test_trainer_loggers_property():
     trainer = Trainer(logger={"log1": logger1, "log2": logger2})
     assert trainer.logger == logger1
     assert trainer.loggers == [logger1, logger2]
-    assert isinstance(trainer.logger_map, dict)
-    assert trainer.logger_map == {"log1": logger1, "log2": logger2}
-
-    trainer.loggers.append(logger3)
-    assert trainer.loggers == [logger1, logger2, logger3]
-    assert trainer.logger_map == {"log1": logger1, "log2": logger2}
+    assert trainer.loggers["log1"] is logger1
+    assert trainer.loggers["log2"] is logger2
 
 
 def test_trainer_loggers_setters():
     """Test the behavior of setters for trainer.logger and trainer.loggers."""
     logger1 = CustomLogger()
     logger2 = CustomLogger()
-    logger3 = CustomLogger()
+    CustomLogger()
 
     trainer = Trainer()
     assert type(trainer.logger) is TensorBoardLogger
@@ -78,46 +71,45 @@ def test_trainer_loggers_setters():
     assert trainer.logger is None
     assert trainer.loggers == []
     assert isinstance(trainer.loggers, list)
-    assert trainer.logger_map == {}
 
     # Test setters for trainer.loggers
     trainer.loggers = [logger1, logger2]
     assert trainer.loggers == [logger1, logger2]
     assert isinstance(trainer.loggers, list)
-    assert trainer.logger_map == {}
 
     trainer.loggers = [logger1]
     assert trainer.loggers == [logger1]
     assert trainer.logger == logger1
-    assert trainer.logger_map == {}
 
     trainer.loggers = []
     assert trainer.loggers == []
     assert trainer.logger is None
     assert isinstance(trainer.loggers, list)
-    assert trainer.logger_map == {}
 
     trainer.loggers = None
     assert trainer.loggers == []
     assert trainer.logger is None
     assert isinstance(trainer.loggers, list)
-    assert trainer.logger_map == {}
+
+    trainer.loggers = {}
+    assert trainer.loggers == []
+    assert trainer.logger is None
+    assert isinstance(trainer.loggers, list)
 
     trainer.loggers = {"log1": logger1, "log2": logger2}
     assert trainer.loggers == [logger1, logger2]
     assert isinstance(trainer.loggers, list)
-    assert isinstance(trainer.logger_map, dict)
-    assert trainer.logger_map == {"log1": logger1, "log2": logger2}
 
-    trainer.loggers.append(logger3)
-    assert trainer.logger_map == {"log1": logger1, "log2": logger2}
+    assert trainer.loggers["log1"] is logger1
+    assert trainer.loggers["log2"] is logger2
 
 
 @pytest.mark.parametrize(
     "logger_value",
     [
         False,
         [],
+        {},
     ],
 )
 def test_no_logger(tmp_path, logger_value):
@@ -130,4 +122,3 @@ def test_no_logger(tmp_path, logger_value):
     assert trainer.logger is None
     assert trainer.loggers == []
     assert trainer.log_dir == str(tmp_path)
-    assert trainer.logger_map == {}