Skip to content

Commit 056bb08

Browse files
authored
Avoid overwriting the lightning_app entry point (#20041)
* don't overwrite lightning_app entry point * bump version * trigger ci
1 parent 8b69285 commit 056bb08

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

.github/workflows/ci-pkg-install.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,14 @@ jobs:
7373
pkg-extra: ${{ matrix.pkg-extra }}
7474

7575
- name: Run CLI (via python)
76-
if: ${{ (matrix.pkg-name == 'lightning' || matrix.pkg-name == 'notset') && matrix.pkg-extra == 'app' }}
76+
if: ${{ (matrix.pkg-name == 'lightning' || matrix.pkg-name == 'notset') }}
7777
run: python -m lightning --version
78+
7879
- name: Run CLI (direct bash)
7980
if: |
80-
((matrix.pkg-name == 'lightning' || matrix.pkg-name == 'notset') && matrix.pkg-extra == 'app') ||
81+
((matrix.pkg-name == 'lightning' || matrix.pkg-name == 'notset') ||
8182
matrix.pkg-name == 'app'
82-
run: lightning_app --version
83+
run: lightning --version
8384

8485
- name: DocTests actions
8586
working-directory: .actions/

src/lightning/__setup__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ def _setup_args() -> Dict[str, Any]:
114114
"console_scripts": [
115115
"fabric = lightning.fabric.cli:_main",
116116
"lightning = lightning.fabric.cli:_legacy_main",
117-
"lightning_app = lightning:_cli_entry_point",
118117
],
119118
},
120119
"setup_requires": [],

src/lightning/fabric/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
66

77

8+
89
## [2.3.0] - 2024-06-13
910

1011
### Added

src/version.info

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.3.1
1+
2.3.2

0 commit comments

Comments
 (0)