Skip to content

Commit 1091484

Browse files
awaelchlilexierule
authored andcommitted
Release 1.9.3
1 parent f588893 commit 1091484

File tree

6 files changed

+29
-33
lines changed

6 files changed

+29
-33
lines changed

.github/workflows/ci-tests-pytorch.yml

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -142,22 +142,25 @@ jobs:
142142
# pip install -r requirements/pytorch/strategies.txt --find-links ${TORCH_URL}
143143
pip list
144144
145-
- name: Reinstall Horovod if necessary
146-
if: runner.os != 'windows'
147-
env:
148-
HOROVOD_BUILD_ARCH_FLAGS: "-mfma"
149-
HOROVOD_WITHOUT_MXNET: 1
150-
HOROVOD_WITHOUT_TENSORFLOW: 1
151-
run: |
152-
HOROVOD_BUILT=$(python -c "import horovod.torch; horovod.torch.nccl_built(); print('SUCCESS')" || true)
153-
if [[ $HOROVOD_BUILT != "SUCCESS" ]]; then
154-
pip uninstall -y horovod
155-
grep "horovod" requirements/pytorch/strategies.txt > requirements/pytorch/horovod.txt
156-
pip install --no-cache-dir -r requirements/pytorch/horovod.txt
157-
fi
158-
horovodrun --check-build
159-
python -c "import horovod.torch"
160-
pip list
145+
# - name: Reinstall Horovod if necessary
146+
# if: runner.os != 'windows'
147+
# env:
148+
# HOROVOD_BUILD_ARCH_FLAGS: "-mfma"
149+
# HOROVOD_WITHOUT_MXNET: 1
150+
# HOROVOD_WITHOUT_TENSORFLOW: 1
151+
# run: |
152+
# HOROVOD_BUILT=$(python -c "import horovod.torch; horovod.torch.nccl_built(); print('SUCCESS')" || true)
153+
# if [[ $HOROVOD_BUILT != "SUCCESS" ]]; then
154+
# pip uninstall -y horovod
155+
# # grep "horovod" requirements/pytorch/strategies.txt > requirements/pytorch/horovod.txt
156+
# # pip install --no-cache-dir -r requirements/pytorch/horovod.txt
157+
#
158+
# # we hardcode the version for testing due to difficulties installing and compiling the package
159+
# pip install --no-cache-dir horovod==0.21.2
160+
# fi
161+
# horovodrun --check-build
162+
# python -c "import horovod.torch"
163+
# pip list
161164

162165
- name: Cache datasets
163166
uses: actions/cache@v3

src/lightning_app/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
66

7+
## [1.9.3] - 2023-02-21
8+
9+
### Fixed
10+
11+
- Fixed `lightning open` command and improved redirects ([#16794](https://github.com/Lightning-AI/lightning/pull/16794))
12+
713

814
## [1.9.2] - 2023-02-15
915

src/lightning_fabric/CHANGELOG.md

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,7 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
66

77

8-
## [1.9.3] - 2023-MM-DD
9-
10-
### Added
11-
12-
13-
### Changed
14-
15-
16-
### Deprecated
17-
18-
-
19-
20-
21-
### Removed
8+
## [1.9.3] - 2023-02-21
229

2310
### Fixed
2411

src/pytorch_lightning/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
66

77

8-
## [1.9.3] - YYYY-MM-DD
8+
## [1.9.3] - 2023-02-21
99

1010
### Fixed
1111

src/version.info

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.9.2
1+
1.9.3

tests/tests_app/runners/test_cloud.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2048,7 +2048,7 @@ def test_get_app_url(monkeypatch, project, run_instance, user, tab, lightning_cl
20482048
runtime = CloudRuntime()
20492049

20502050
with mock.patch(
2051-
"lightning.app.runners.cloud.get_lightning_cloud_url", mock.MagicMock(return_value=lightning_cloud_url)
2051+
"lightning_app.runners.cloud.get_lightning_cloud_url", mock.MagicMock(return_value=lightning_cloud_url)
20522052
):
20532053
assert runtime._get_app_url(project, run_instance, tab) == expected_url
20542054

0 commit comments

Comments
 (0)