Skip to content

Commit 11bac94

Browse files
authored
Drop nvtx test (#19154)
1 parent df869c9 commit 11bac94

File tree

3 files changed

+2
-31
lines changed

3 files changed

+2
-31
lines changed

tests/run_standalone_tests.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ test_path=$1
3131
printf "source path: $test_path\n"
3232

3333
# collect all tests with parametrization based filtering with PL_RUN_STANDALONE_TESTS
34-
standalone_tests=$(python -m pytest $test_path -q --collect-only --pythonwarnings ignore)
34+
standalone_tests=$(python3 -m pytest $test_path -q --collect-only --pythonwarnings ignore)
3535
printf "Collected tests: \n $standalone_tests"
3636
# match only lines with tests
3737
parametrizations=$(grep -oP '\S+::test_\S+' <<< "$standalone_tests")
@@ -69,7 +69,7 @@ for i in "${!parametrizations_arr[@]}"; do
6969
# execute the test in the background
7070
# redirect to a log file that buffers test output. since the tests will run in the background, we cannot let them
7171
# output to std{out,err} because the outputs would be garbled together
72-
python ${defaults} "$parametrization" &>> standalone_test_output.txt &
72+
python3 ${defaults} "$parametrization" &>> standalone_test_output.txt &
7373
# save the PID in an array
7474
pids[${i}]=$!
7575
# add row to the final report

tests/tests_pytorch/profilers/test_profiler.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -471,24 +471,6 @@ def look_for_trace(trace_dir):
471471
assert look_for_trace(tmpdir / "lightning_logs" / "version_0")
472472

473473

474-
# Todo: this test has not been running as all our CI GPU runners have higher capacity
475-
# @RunIf(min_cuda_gpus=1, standalone=True)
476-
# @pytest.mark.skipif(torch.cuda.get_device_capability()[0] >= 8)
477-
# def test_pytorch_profiler_nested_emit_nvtx():
478-
# """This test check emit_nvtx is correctly supported."""
479-
# profiler = PyTorchProfiler(use_cuda=True, emit_nvtx=True)
480-
# model = BoringModel()
481-
# trainer = Trainer(
482-
# fast_dev_run=True,
483-
# profiler=profiler,
484-
# accelerator="gpu",
485-
# devices=1,
486-
# enable_progress_bar=False,
487-
# enable_model_summary=False,
488-
# )
489-
# trainer.fit(model)
490-
491-
492474
def test_register_record_function(tmpdir):
493475
use_cuda = torch.cuda.is_available()
494476
pytorch_profiler = PyTorchProfiler(

tests/tests_pytorch/run_standalone_tasks.sh

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,6 @@ set -e
1818
# this environment variable allows special tests to run
1919
export PL_RUN_STANDALONE_TESTS=1
2020

21-
#can_run_nvprof=$(python -c "import torch; print(torch.cuda.is_available() and torch.cuda.get_device_capability()[0] < 8)")
22-
#if [[ $can_run_nvprof == "True" ]]; then
23-
# echo "Running profilers/test_profiler.py::test_pytorch_profiler_nested_emit_nvtx"
24-
# nvprof --profile-from-start off \
25-
# -o trace_name.prof \
26-
# -- python -m coverage run \
27-
# --source lightning.pytorch \
28-
# --append -m pytest \
29-
# --no-header profilers/test_profiler.py::test_pytorch_profiler_nested_emit_nvtx
30-
#fi
31-
3221
# test that a user can manually launch individual processes
3322
echo "Running manual ddp launch test"
3423
export PYTHONPATH="${PYTHONPATH}:$(pwd)"

0 commit comments

Comments
 (0)