code reviews and rebase

Author: rohitgr7

pytorch_lightning/core/saving.py

@@ -385,8 +385,7 @@ def save_hparams_to_yaml(config_yaml, hparams: Union[dict, Namespace], use_omega
     # drop paramaters which contain some strange datatypes as fsspec
     for k, v in hparams.items():
         try:
-            if isinstance(v, Enum):
-                v = deepcopy(v.name)
+            v = v.name if isinstance(v, Enum) else v
             yaml.dump(v)
         except TypeError:
             warn(f"Skipping '{k}' parameter because it is not possible to safely dump to YAML.")

tests/models/test_hparams.py

@@ -493,7 +493,7 @@ class Options(str, Enum):
     )
     path_yaml = os.path.join(tmpdir, "testing-hparams.yaml")
 
-    def compare(loaded_params, default_params: dict):
+    def _compare_params(loaded_params, default_params: dict):
         assert isinstance(loaded_params, (dict, DictConfig))
         assert loaded_params.keys() == default_params.keys()
         for k, v in default_params.items():
@@ -503,16 +503,16 @@ def compare(loaded_params, default_params: dict):
                 assert v == loaded_params[k]
 
     save_hparams_to_yaml(path_yaml, hparams)
-    compare(load_hparams_from_yaml(path_yaml, use_omegaconf=False), hparams)
+    _compare_params(load_hparams_from_yaml(path_yaml, use_omegaconf=False), hparams)
 
     save_hparams_to_yaml(path_yaml, Namespace(**hparams))
-    compare(load_hparams_from_yaml(path_yaml, use_omegaconf=False), hparams)
+    _compare_params(load_hparams_from_yaml(path_yaml, use_omegaconf=False), hparams)
 
     save_hparams_to_yaml(path_yaml, AttributeDict(hparams))
-    compare(load_hparams_from_yaml(path_yaml, use_omegaconf=False), hparams)
+    _compare_params(load_hparams_from_yaml(path_yaml, use_omegaconf=False), hparams)
 
     save_hparams_to_yaml(path_yaml, OmegaConf.create(hparams))
-    compare(load_hparams_from_yaml(path_yaml), hparams)
+    _compare_params(load_hparams_from_yaml(path_yaml), hparams)
 
 
 class NoArgsSubClassBoringModel(CustomBoringModel):