Skip to content

Commit 18bba25

Browse files
authored
fix command line run for refinforce_learn_qnet in pl_examples (#5414)
* fix wrong argument in argparse * remove wrong default arg in argparser * disable add help argparse
1 parent 18d2ae8 commit 18bba25

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

pl_examples/domain_templates/reinforce_learn_Qnet.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -393,17 +393,13 @@ def add_model_specific_args(parent_parser): # pragma: no-cover
393393
help="how many frames do we update the target network")
394394
parser.add_argument("--replay_size", type=int, default=1000,
395395
help="capacity of the replay buffer")
396-
parser.add_argument("--warm_start_size", type=int, default=1000,
396+
parser.add_argument("--warm_start_steps", type=int, default=1000,
397397
help="how many samples do we use to fill our buffer at the start of training")
398398
parser.add_argument("--eps_last_frame", type=int, default=1000,
399399
help="what frame should epsilon stop decaying")
400400
parser.add_argument("--eps_start", type=float, default=1.0, help="starting value of epsilon")
401401
parser.add_argument("--eps_end", type=float, default=0.01, help="final value of epsilon")
402402
parser.add_argument("--episode_length", type=int, default=200, help="max length of an episode")
403-
parser.add_argument("--max_episode_reward", type=int, default=200,
404-
help="max episode reward in the environment")
405-
parser.add_argument("--warm_start_steps", type=int, default=1000,
406-
help="max episode reward in the environment")
407403
return parser
408404

409405

@@ -424,7 +420,7 @@ def main(args) -> None:
424420
torch.manual_seed(0)
425421
np.random.seed(0)
426422

427-
parser = argparse.ArgumentParser()
423+
parser = argparse.ArgumentParser(add_help=False)
428424
parser = DQNLightning.add_model_specific_args(parser)
429425
args = parser.parse_args()
430426

0 commit comments

Comments
 (0)