Skip to content

Commit 1a332e8

Browse files
dominicgkerrdominicgkerr
authored
Merge branch 'Lightning-AI:master' into feature/19743-tensorboard-histograms
2 parents 3851846 + 0f12271 commit 1a332e8

File tree

128 files changed

+730
-1066
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

128 files changed

+730
-1066
lines changed

‎.azure/gpu-benchmarks.yml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ jobs:
4646
variables:
4747
DEVICES: $( python -c 'print("$(Agent.Name)".split("_")[-1])' )
4848
container:
49-
# TODO: Upgrade to Python 3.11
50-
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.10-torch2.2-cuda12.1.0"
49+
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.11-torch2.3-cuda12.1.0"
5150
options: "--gpus=all --shm-size=32g"
5251
strategy:
5352
matrix:

‎.azure/gpu-tests-fabric.yml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,11 @@ jobs:
5656
options: "--gpus=all --shm-size=2gb -v /var/tmp:/var/tmp"
5757
strategy:
5858
matrix:
59-
# TODO: Upgrade to Python 3.11
6059
"Fabric | latest":
61-
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.10-torch2.2-cuda12.1.0"
60+
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.11-torch2.3-cuda12.1.0"
6261
PACKAGE_NAME: "fabric"
6362
"Lightning | latest":
64-
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.10-torch2.2-cuda12.1.0"
63+
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.11-torch2.3-cuda12.1.0"
6564
PACKAGE_NAME: "lightning"
6665
workspace:
6766
clean: all

‎.azure/gpu-tests-pytorch.yml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,11 @@ jobs:
4848
cancelTimeoutInMinutes: "2"
4949
strategy:
5050
matrix:
51-
# TODO: Upgrade to Python 3.11
5251
"PyTorch | latest":
53-
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.10-torch2.2-cuda12.1.0"
52+
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.11-torch2.3-cuda12.1.0"
5453
PACKAGE_NAME: "pytorch"
5554
"Lightning | latest":
56-
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.10-torch2.2-cuda12.1.0"
55+
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.11-torch2.3-cuda12.1.0"
5756
PACKAGE_NAME: "lightning"
5857
pool: lit-rtx-3090
5958
variables:

‎.github/checkgroup.yml‎

Lines changed: 30 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,24 @@ subprojects:
1919
- "!*.md"
2020
- "!**/*.md"
2121
checks:
22-
- "pl-cpu (macOS-11, lightning, 3.8, 1.13, oldest)"
23-
- "pl-cpu (macOS-11, lightning, 3.10, 1.13)"
22+
- "pl-cpu (macOS-11, lightning, 3.8, 2.0, oldest)"
23+
- "pl-cpu (macOS-11, lightning, 3.10, 2.0)"
2424
- "pl-cpu (macOS-11, lightning, 3.10, 2.1)"
2525
- "pl-cpu (macOS-11, lightning, 3.10, 2.2)"
26-
- "pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest)"
27-
- "pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)"
26+
- "pl-cpu (macOS-14, lightning, 3.10, 2.3)"
27+
- "pl-cpu (ubuntu-20.04, lightning, 3.8, 2.0, oldest)"
28+
- "pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)"
2829
- "pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1)"
2930
- "pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2)"
30-
- "pl-cpu (windows-2022, lightning, 3.8, 1.13, oldest)"
31-
- "pl-cpu (windows-2022, lightning, 3.10, 1.13)"
31+
- "pl-cpu (ubuntu-20.04, lightning, 3.10, 2.3)"
32+
- "pl-cpu (windows-2022, lightning, 3.8, 2.0, oldest)"
33+
- "pl-cpu (windows-2022, lightning, 3.10, 2.0)"
3234
- "pl-cpu (windows-2022, lightning, 3.10, 2.1)"
3335
- "pl-cpu (windows-2022, lightning, 3.10, 2.2)"
34-
- "pl-cpu (macOS-11, pytorch, 3.8, 1.13)"
35-
- "pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)"
36-
- "pl-cpu (windows-2022, pytorch, 3.8, 1.13)"
36+
- "pl-cpu (windows-2022, lightning, 3.10, 2.3)"
37+
- "pl-cpu (macOS-11, pytorch, 3.8, 2.0)"
38+
- "pl-cpu (ubuntu-20.04, pytorch, 3.8, 2.0)"
39+
- "pl-cpu (windows-2022, pytorch, 3.8, 2.0)"
3740
- "pl-cpu (macOS-12, pytorch, 3.11, 2.0)"
3841
- "pl-cpu (macOS-12, pytorch, 3.11, 2.1)"
3942
- "pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0)"
@@ -140,15 +143,17 @@ subprojects:
140143
- "!*.md"
141144
- "!**/*.md"
142145
checks:
143-
- "build-cuda (3.9, 1.13, 11.8.0)"
144-
- "build-cuda (3.9, 1.13, 12.0.1)"
145146
- "build-cuda (3.10, 2.0, 11.8.0)"
146147
- "build-cuda (3.10, 2.1, 12.1.0)"
148+
- "build-cuda (3.10, 2.2, 12.1.0)"
149+
- "build-cuda (3.11, 2.1, 12.1.0)"
150+
- "build-cuda (3.11, 2.2, 12.1.0)"
147151
#- "build-NGC"
148-
- "build-pl (3.9, 1.13, 11.8.0)"
149-
- "build-pl (3.9, 1.13, 12.0.1)"
150152
- "build-pl (3.10, 2.0, 11.8.0)"
151153
- "build-pl (3.10, 2.1, 12.1.0)"
154+
- "build-pl (3.10, 2.2, 12.1.0)"
155+
- "build-pl (3.11, 2.1, 12.1.0)"
156+
- "build-pl (3.11, 2.2, 12.1.0)"
152157

153158
# SECTION: lightning_fabric
154159

@@ -165,21 +170,24 @@ subprojects:
165170
- "!*.md"
166171
- "!**/*.md"
167172
checks:
168-
- "fabric-cpu (macOS-11, lightning, 3.8, 1.13, oldest)"
169-
- "fabric-cpu (macOS-11, lightning, 3.10, 1.13)"
173+
- "fabric-cpu (macOS-11, lightning, 3.8, 2.0, oldest)"
174+
- "fabric-cpu (macOS-11, lightning, 3.10, 2.0)"
170175
- "fabric-cpu (macOS-11, lightning, 3.11, 2.1)"
171176
- "fabric-cpu (macOS-11, lightning, 3.11, 2.2)"
172-
- "fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest)"
173-
- "fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)"
177+
- "fabric-cpu (macOS-14, lightning, 3.10, 2.3)"
178+
- "fabric-cpu (ubuntu-20.04, lightning, 3.8, 2.0, oldest)"
179+
- "fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)"
174180
- "fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1)"
175181
- "fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2)"
176-
- "fabric-cpu (windows-2022, lightning, 3.8, 1.13, oldest)"
177-
- "fabric-cpu (windows-2022, lightning, 3.10, 1.13)"
182+
- "fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3)"
183+
- "fabric-cpu (windows-2022, lightning, 3.8, 2.0, oldest)"
184+
- "fabric-cpu (windows-2022, lightning, 3.10, 2.0)"
178185
- "fabric-cpu (windows-2022, lightning, 3.11, 2.1)"
179186
- "fabric-cpu (windows-2022, lightning, 3.11, 2.2)"
180-
- "fabric-cpu (macOS-11, fabric, 3.8, 1.13)"
181-
- "fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)"
182-
- "fabric-cpu (windows-2022, fabric, 3.8, 1.13)"
187+
- "fabric-cpu (windows-2022, lightning, 3.11, 2.3)"
188+
- "fabric-cpu (macOS-11, fabric, 3.8, 2.0)"
189+
- "fabric-cpu (ubuntu-20.04, fabric, 3.8, 2.0)"
190+
- "fabric-cpu (windows-2022, fabric, 3.8, 2.0)"
183191
- "fabric-cpu (macOS-12, fabric, 3.11, 2.0)"
184192
- "fabric-cpu (macOS-12, fabric, 3.11, 2.1)"
185193
- "fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0)"

‎.github/workflows/ci-tests-fabric.yml‎

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,19 @@ jobs:
3939
fail-fast: false
4040
matrix:
4141
include:
42-
- { os: "macOS-11", pkg-name: "lightning", python-version: "3.10", pytorch-version: "1.13" }
43-
- { os: "ubuntu-20.04", pkg-name: "lightning", python-version: "3.10", pytorch-version: "1.13" }
44-
- { os: "windows-2022", pkg-name: "lightning", python-version: "3.10", pytorch-version: "1.13" }
42+
- { os: "macOS-11", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.0" }
43+
- { os: "ubuntu-20.04", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.0" }
44+
- { os: "windows-2022", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.0" }
4545
# only run PyTorch latest
4646
- { os: "macOS-11", pkg-name: "lightning", python-version: "3.11", pytorch-version: "2.1" }
4747
- { os: "ubuntu-20.04", pkg-name: "lightning", python-version: "3.11", pytorch-version: "2.1" }
4848
- { os: "windows-2022", pkg-name: "lightning", python-version: "3.11", pytorch-version: "2.1" }
4949
- { os: "macOS-11", pkg-name: "lightning", python-version: "3.11", pytorch-version: "2.2" }
5050
- { os: "ubuntu-20.04", pkg-name: "lightning", python-version: "3.11", pytorch-version: "2.2" }
5151
- { os: "windows-2022", pkg-name: "lightning", python-version: "3.11", pytorch-version: "2.2" }
52+
- { os: "macOS-14", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.3" }
53+
- { os: "ubuntu-20.04", pkg-name: "lightning", python-version: "3.11", pytorch-version: "2.3" }
54+
- { os: "windows-2022", pkg-name: "lightning", python-version: "3.11", pytorch-version: "2.3" }
5255
# only run PyTorch latest with Python latest, use Fabric scope to limit dependency issues
5356
- { os: "macOS-12", pkg-name: "fabric", python-version: "3.11", pytorch-version: "2.0" }
5457
- { os: "ubuntu-22.04", pkg-name: "fabric", python-version: "3.11", pytorch-version: "2.0" }
@@ -57,38 +60,34 @@ jobs:
5760
- { os: "ubuntu-22.04", pkg-name: "fabric", python-version: "3.11", pytorch-version: "2.1" }
5861
- { os: "windows-2022", pkg-name: "fabric", python-version: "3.11", pytorch-version: "2.1" }
5962
# "oldest" versions tests, only on minimum Python
60-
- {
61-
os: "macOS-11",
62-
pkg-name: "lightning",
63-
python-version: "3.8",
64-
pytorch-version: "1.13",
65-
requires: "oldest",
66-
}
63+
- { os: "macOS-11", pkg-name: "lightning", python-version: "3.8", pytorch-version: "2.0", requires: "oldest" }
6764
- {
6865
os: "ubuntu-20.04",
6966
pkg-name: "lightning",
7067
python-version: "3.8",
71-
pytorch-version: "1.13",
68+
pytorch-version: "2.0",
7269
requires: "oldest",
7370
}
7471
- {
7572
os: "windows-2022",
7673
pkg-name: "lightning",
7774
python-version: "3.8",
78-
pytorch-version: "1.13",
75+
pytorch-version: "2.0",
7976
requires: "oldest",
8077
}
8178
# "fabric" installs the standalone package
82-
- { os: "macOS-11", pkg-name: "fabric", python-version: "3.8", pytorch-version: "1.13" }
83-
- { os: "ubuntu-20.04", pkg-name: "fabric", python-version: "3.8", pytorch-version: "1.13" }
84-
- { os: "windows-2022", pkg-name: "fabric", python-version: "3.8", pytorch-version: "1.13" }
79+
- { os: "macOS-11", pkg-name: "fabric", python-version: "3.8", pytorch-version: "2.0" }
80+
- { os: "ubuntu-20.04", pkg-name: "fabric", python-version: "3.8", pytorch-version: "2.0" }
81+
- { os: "windows-2022", pkg-name: "fabric", python-version: "3.8", pytorch-version: "2.0" }
8582
timeout-minutes: 25 # because of building grpcio on Mac
8683
env:
8784
PACKAGE_NAME: ${{ matrix.pkg-name }}
8885
FREEZE_REQUIREMENTS: ${{ ! (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release/')) }}
8986
PYPI_CACHE_DIR: "_pip-wheels"
9087
TORCH_URL_STABLE: "https://download.pytorch.org/whl/cpu/torch_stable.html"
9188
TORCH_URL_TEST: "https://download.pytorch.org/whl/test/cpu/torch_test.html"
89+
# TODO: Remove this - Enable running MPS tests on this platform
90+
DISABLE_MPS: ${{ matrix.os == 'macOS-14' && '1' || '0' }}
9291
steps:
9392
- uses: actions/checkout@v4
9493

@@ -125,7 +124,7 @@ jobs:
125124
- name: Env. variables
126125
run: |
127126
# Switch PyTorch URL
128-
python -c "print('TORCH_URL=' + str('${{env.TORCH_URL_TEST}}' if '${{ matrix.pytorch-version }}' == '2.2' else '${{env.TORCH_URL_STABLE}}'))" >> $GITHUB_ENV
127+
python -c "print('TORCH_URL=' + str('${{env.TORCH_URL_TEST}}' if '${{ matrix.pytorch-version }}' == '2.3' else '${{env.TORCH_URL_STABLE}}'))" >> $GITHUB_ENV
129128
# Switch coverage scope
130129
python -c "print('COVERAGE_SCOPE=' + str('lightning' if '${{matrix.pkg-name}}' == 'lightning' else 'lightning_fabric'))" >> $GITHUB_ENV
131130
# if you install mono-package set dependency only for this subpackage

‎.github/workflows/ci-tests-pytorch.yml‎

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,19 @@ jobs:
4343
fail-fast: false
4444
matrix:
4545
include:
46-
- { os: "macOS-11", pkg-name: "lightning", python-version: "3.10", pytorch-version: "1.13" }
47-
- { os: "ubuntu-20.04", pkg-name: "lightning", python-version: "3.10", pytorch-version: "1.13" }
48-
- { os: "windows-2022", pkg-name: "lightning", python-version: "3.10", pytorch-version: "1.13" }
46+
- { os: "macOS-11", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.0" }
47+
- { os: "ubuntu-20.04", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.0" }
48+
- { os: "windows-2022", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.0" }
4949
# only run PyTorch latest
5050
- { os: "macOS-11", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.1" }
5151
- { os: "ubuntu-20.04", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.1" }
5252
- { os: "windows-2022", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.1" }
5353
- { os: "macOS-11", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.2" }
5454
- { os: "ubuntu-20.04", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.2" }
5555
- { os: "windows-2022", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.2" }
56+
- { os: "macOS-14", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.3" }
57+
- { os: "ubuntu-20.04", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.3" }
58+
- { os: "windows-2022", pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.3" }
5659
# only run PyTorch latest with Python latest, use PyTorch scope to limit dependency issues
5760
- { os: "macOS-12", pkg-name: "pytorch", python-version: "3.11", pytorch-version: "2.0" }
5861
- { os: "ubuntu-22.04", pkg-name: "pytorch", python-version: "3.11", pytorch-version: "2.0" }
@@ -61,31 +64,25 @@ jobs:
6164
- { os: "ubuntu-22.04", pkg-name: "pytorch", python-version: "3.11", pytorch-version: "2.1" }
6265
- { os: "windows-2022", pkg-name: "pytorch", python-version: "3.11", pytorch-version: "2.1" }
6366
# "oldest" versions tests, only on minimum Python
64-
- {
65-
os: "macOS-11",
66-
pkg-name: "lightning",
67-
python-version: "3.8",
68-
pytorch-version: "1.13",
69-
requires: "oldest",
70-
}
67+
- { os: "macOS-11", pkg-name: "lightning", python-version: "3.8", pytorch-version: "2.0", requires: "oldest" }
7168
- {
7269
os: "ubuntu-20.04",
7370
pkg-name: "lightning",
7471
python-version: "3.8",
75-
pytorch-version: "1.13",
72+
pytorch-version: "2.0",
7673
requires: "oldest",
7774
}
7875
- {
7976
os: "windows-2022",
8077
pkg-name: "lightning",
8178
python-version: "3.8",
82-
pytorch-version: "1.13",
79+
pytorch-version: "2.0",
8380
requires: "oldest",
8481
}
8582
# "pytorch" installs the standalone package
86-
- { os: "macOS-11", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.13" }
87-
- { os: "ubuntu-20.04", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.13" }
88-
- { os: "windows-2022", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.13" }
83+
- { os: "macOS-11", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "2.0" }
84+
- { os: "ubuntu-20.04", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "2.0" }
85+
- { os: "windows-2022", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "2.0" }
8986
timeout-minutes: 50
9087
env:
9188
PACKAGE_NAME: ${{ matrix.pkg-name }}
@@ -94,6 +91,8 @@ jobs:
9491
TORCH_URL_TEST: "https://download.pytorch.org/whl/test/cpu/torch_test.html"
9592
FREEZE_REQUIREMENTS: ${{ ! (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release/')) }}
9693
PYPI_CACHE_DIR: "_pip-wheels"
94+
# TODO: Remove this - Enable running MPS tests on this platform
95+
DISABLE_MPS: ${{ matrix.os == 'macOS-14' && '1' || '0' }}
9796
steps:
9897
- uses: actions/checkout@v4
9998

@@ -131,7 +130,7 @@ jobs:
131130
- name: Env. variables
132131
run: |
133132
# Switch PyTorch URL
134-
python -c "print('TORCH_URL=' + str('${{env.TORCH_URL_TEST}}' if '${{ matrix.pytorch-version }}' == '2.2' else '${{env.TORCH_URL_STABLE}}'))" >> $GITHUB_ENV
133+
python -c "print('TORCH_URL=' + str('${{env.TORCH_URL_TEST}}' if '${{ matrix.pytorch-version }}' == '2.3' else '${{env.TORCH_URL_STABLE}}'))" >> $GITHUB_ENV
135134
# Switch coverage scope
136135
python -c "print('COVERAGE_SCOPE=' + str('lightning' if '${{matrix.pkg-name}}' == 'lightning' else 'pytorch_lightning'))" >> $GITHUB_ENV
137136
# if you install mono-package set dependency only for this subpackage

‎.github/workflows/docker-build.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,11 @@ jobs:
4343
include:
4444
# We only release one docker image per PyTorch version.
4545
# Make sure the matrix here matches the one below.
46-
- { python_version: "3.9", pytorch_version: "1.13", cuda_version: "11.8.0" }
47-
- { python_version: "3.9", pytorch_version: "1.13", cuda_version: "12.0.1" }
4846
- { python_version: "3.10", pytorch_version: "2.0", cuda_version: "11.8.0" }
4947
- { python_version: "3.10", pytorch_version: "2.1", cuda_version: "12.1.0" }
48+
- { python_version: "3.10", pytorch_version: "2.2", cuda_version: "12.1.0" }
49+
- { python_version: "3.11", pytorch_version: "2.1", cuda_version: "12.1.0" }
50+
- { python_version: "3.11", pytorch_version: "2.2", cuda_version: "12.1.0" }
5051
steps:
5152
- uses: actions/checkout@v4
5253
with:
@@ -103,13 +104,12 @@ jobs:
103104
include:
104105
# These are the base images for PL release docker images.
105106
# Make sure the matrix here matches the one above.
106-
- { python_version: "3.9", pytorch_version: "1.13", cuda_version: "11.8.0" }
107-
- { python_version: "3.9", pytorch_version: "1.13", cuda_version: "12.0.1" }
108107
- { python_version: "3.10", pytorch_version: "2.0", cuda_version: "11.8.0" }
109108
- { python_version: "3.10", pytorch_version: "2.1", cuda_version: "12.1.0" }
110109
- { python_version: "3.10", pytorch_version: "2.2", cuda_version: "12.1.0" }
111110
- { python_version: "3.11", pytorch_version: "2.1", cuda_version: "12.1.0" }
112111
- { python_version: "3.11", pytorch_version: "2.2", cuda_version: "12.1.0" }
112+
- { python_version: "3.11", pytorch_version: "2.3", cuda_version: "12.1.0" }
113113
# - { python_version: "3.12", pytorch_version: "2.2", cuda_version: "12.1.0" } # todo: pending on `onnxruntime`
114114
steps:
115115
- uses: actions/checkout@v4

‎.pre-commit-config.yaml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ repos:
7070
- id: sphinx-lint
7171

7272
- repo: https://github.com/astral-sh/ruff-pre-commit
73-
rev: v0.3.2
73+
rev: v0.3.5
7474
hooks:
7575
# try to fix what is possible
7676
- id: ruff
@@ -101,4 +101,5 @@ repos:
101101
hooks:
102102
- id: prettier
103103
# https://prettier.io/docs/en/options.html#print-width
104+
files: \.(json|yml|yaml|toml)
104105
args: ["--print-width=120"]

‎.prettierignore‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎dockers/base-cuda/Dockerfile‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,7 @@ ENV \
3434
MAKEFLAGS="-j2"
3535

3636
RUN \
37-
# TODO: Remove the manual key installation once the base image is updated.
38-
# https://github.com/NVIDIA/nvidia-docker/issues/1631
39-
# https://github.com/NVIDIA/nvidia-docker/issues/1631#issuecomment-1264715214
4037
apt-get update && apt-get install -y wget && \
41-
wget https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/3bf863cc.pub && \
42-
mkdir -p /etc/apt/keyrings/ && mv 3bf863cc.pub /etc/apt/keyrings/ && \
43-
echo "deb [signed-by=/etc/apt/keyrings/3bf863cc.pub] https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/ /" /etc/apt/sources.list.d/cuda.list && \
4438
apt-get update -qq --fix-missing && \
4539
NCCL_VER=$(dpkg -s libnccl2 | grep '^Version:' | awk -F ' ' '{print $2}' | awk -F '-' '{print $1}' | grep -ve '^\s*$') && \
4640
CUDA_VERSION_MM=${CUDA_VERSION%.*} && \

0 commit comments

Comments
 (0)