Skip to content

Commit 1ce0df5

Browse files
committed
Fix typing
1 parent ce4763d commit 1ce0df5

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.actions/assistant.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -486,12 +486,13 @@ def convert_version2nightly(ver_file: str = "src/version.info") -> None:
486486
import sys
487487

488488
import jsonargparse
489+
from jsonargparse import ArgumentParser
489490

490-
def _parse_known_args_patch(self, args: Any = None, namespace: Any = None) -> tuple[Any]:
491-
namespace, args = super(jsonargparse.ArgumentParser, self)._parse_known_args(args, namespace, intermixed=False)
491+
def _parse_known_args_patch(self: ArgumentParser, args: Any = None, namespace: Any = None) -> tuple[Any, Any]:
492+
namespace, args = super(ArgumentParser, self)._parse_known_args(args, namespace, intermixed=False)
492493
return namespace, args
493494

494495
if sys.version_info >= (3, 12, 8):
495-
setattr(jsonargparse.ArgumentParser, "_parse_known_args", _parse_known_args_patch)
496+
setattr(ArgumentParser, "_parse_known_args", _parse_known_args_patch)
496497

497498
jsonargparse.CLI(AssistantCLI, as_positional=False)

src/lightning/pytorch/cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
set_config_read_mode,
4949
)
5050

51-
def _parse_known_args_patch(self, args: Any = None, namespace: Any = None) -> tuple[Any]:
51+
def _parse_known_args_patch(self: ArgumentParser, args: Any = None, namespace: Any = None) -> tuple[Any, Any]:
5252
namespace, args = super(ArgumentParser, self)._parse_known_args(args, namespace, intermixed=False)
5353
return namespace, args
5454

0 commit comments

Comments
 (0)