Skip to content

Commit 23260a6

Browse files
pl-ghostBordapre-commit-ci[bot]
authored andcommitted
docs: update ref to latest tutorials & fix CI trigger (#18787)
Co-authored-by: Borda <[email protected]> Co-authored-by: Jirka <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 2306429)
1 parent 2c11b81 commit 23260a6

File tree

5 files changed

+13
-18
lines changed

5 files changed

+13
-18
lines changed

.github/checkgroup.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ subprojects:
121121
- "src/lightning/pytorch/**"
122122
- "src/pytorch_lightning/*"
123123
- "docs/source-pytorch/**"
124+
- "_notebooks"
124125
- ".actions/*"
125126
- ".github/workflows/docs-build.yml"
126127
- "requirements/docs.txt"

.github/workflows/docs-build.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ on:
1111
paths:
1212
- ".actions/*"
1313
- ".github/workflows/docs-build.yml"
14-
- "requirements/**"
1514
- "docs/**"
15+
- "_notebooks"
16+
- "requirements/**"
1617
- "src/**"
1718
- "setup.py"
1819
- "pyproject.toml" # includes metadata used in the package creation

.github/workflows/docs-tutorials.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ jobs:
2727
- name: initial state
2828
run: |
2929
git submodule status
30-
short_sha=$(git submodule status | grep -A 1 _notebooks | cut -c1-8)
30+
# starting from second char as the line starts with +
31+
short_sha=$(git submodule status | grep -A 1 _notebooks | cut -c2-9)
3132
echo "SHA_ACTUAL=$short_sha" >> $GITHUB_ENV
3233
# Skip smudge - We'll download binary files later in a faster batch
3334
git lfs install --skip-smudge
@@ -41,8 +42,8 @@ jobs:
4142
run: |
4243
git submodule status
4344
git status
44-
45-
short_sha=$(git submodule status | grep -A 1 _notebooks | cut -c1-8)
45+
# starting from second char as the line starts with +
46+
short_sha=$(git submodule status | grep -A 1 _notebooks | cut -c2-9)
4647
echo "SHA_LATEST=$short_sha" >> $GITHUB_ENV
4748
4849
- name: Create Pull Request

_notebooks

docs/source-pytorch/conf.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -70,20 +70,12 @@ def _load_py_module(name: str, location: str) -> ModuleType:
7070
_PATH_HERE,
7171
"notebooks",
7272
patterns=[".", "course_UvA-DL", "lightning_examples"],
73+
# TODO(@aniketmaurya): Complete converting the missing items and add them back
74+
ignore=[
75+
# "course_UvA-DL/13-contrastive-learning",
76+
"lightning_examples/warp-drive",
77+
],
7378
)
74-
# TODO(@aniketmaurya): Complete converting the missing items and add them back
75-
ignore = [
76-
"course_UvA-DL/13-contrastive-learning",
77-
"lightning_examples/augmentation_kornia",
78-
"lightning_examples/finetuning-scheduler",
79-
"lightning_examples/reinforce-learning-DQN",
80-
"lightning_examples/text-transformers",
81-
"lightning_examples/warp-drive",
82-
]
83-
for file in ignore:
84-
file = os.path.join(_PATH_HERE, "notebooks", file)
85-
if os.path.exists(file):
86-
os.remove(file)
8779

8880

8981
os.makedirs(os.path.join(_PATH_HERE, _FOLDER_GENERATED), exist_ok=True)

0 commit comments

Comments
 (0)