Fix warning message formatting in save_hyperparameters (#12498)

awaelchli · web-flow · commit 2de6a9bbbff4 · 2022-03-29T12:46:21.000+09:00
diff --git a/pytorch_lightning/utilities/parsing.py b/pytorch_lightning/utilities/parsing.py
@@ -243,7 +243,7 @@ def save_hyperparameters(
         if isinstance(init_args[k], nn.Module):
             rank_zero_warn(
                 f"Attribute {k!r} is an instance of `nn.Module` and is already saved during checkpointing."
-                f" It is recommended to ignore them using `self.save_hyperparameters(ignore=[{k}!r])`."
+                f" It is recommended to ignore them using `self.save_hyperparameters(ignore=[{k!r}])`."
             )
 
     if not args:

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ def save_hyperparameters(`
`243`	`243`	`if isinstance(init_args[k], nn.Module):`
`244`	`244`	`rank_zero_warn(`
`245`	`245`	f"Attribute {k!r} is an instance of `nn.Module` and is already saved during checkpointing."
`246`		- f" It is recommended to ignore them using `self.save_hyperparameters(ignore=[{k}!r])`."
	`246`	+ f" It is recommended to ignore them using `self.save_hyperparameters(ignore=[{k!r}])`."
`247`	`247`	`)`
`248`	`248`
`249`	`249`	`if not args:`