Skip to content

Commit 3649f73

Browse files
carmoccamauvilsa
authored andcommitted
Update jsonargparse to unblock master (#12884)
Co-authored-by: Mauricio Villegas <[email protected]>
1 parent e41999e commit 3649f73

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

pytorch_lightning/utilities/cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,7 @@ def instantiate_class(args: Union[Any, Tuple[Any, ...]], init: Dict[str, Any]) -
888888

889889

890890
def _get_short_description(component: object) -> Optional[str]:
891-
parse = import_docstring_parse("LightningCLI(run=True)")
891+
parse, _ = import_docstring_parse("LightningCLI(run=True)")
892892
try:
893893
docstring = parse(component.__doc__)
894894
return docstring.short_description

pytorch_lightning/utilities/imports.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def _compare_version(package: str, op: Callable, version: str, use_base_version:
107107
_HOROVOD_AVAILABLE = _module_available("horovod.torch")
108108
_HYDRA_AVAILABLE = _package_available("hydra")
109109
_HYDRA_EXPERIMENTAL_AVAILABLE = _module_available("hydra.experimental")
110-
_JSONARGPARSE_AVAILABLE = _package_available("jsonargparse") and _compare_version("jsonargparse", operator.ge, "4.6.0")
110+
_JSONARGPARSE_AVAILABLE = _package_available("jsonargparse") and _compare_version("jsonargparse", operator.ge, "4.7.1")
111111
_KINETO_AVAILABLE = _TORCH_GREATER_EQUAL_1_8_1 and torch.profiler.kineto_available()
112112
_NEPTUNE_AVAILABLE = _package_available("neptune")
113113
_NEPTUNE_GREATER_EQUAL_0_9 = _NEPTUNE_AVAILABLE and _compare_version("neptune", operator.ge, "0.9.0")

requirements/extra.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ horovod>=0.21.2,!=0.24.0 # no need to install with [pytorch] as pytorch is alre
55
torchtext>=0.9.*
66
omegaconf>=2.0.5
77
hydra-core>=1.0.5
8-
jsonargparse[signatures]>=4.6.0
8+
jsonargparse[signatures]>=4.7.1
99
gcsfs>=2021.5.0
1010
rich>=10.2.2,!=10.15.*

0 commit comments

Comments
 (0)