Skip to content

Commit 369b990

Browse files
dependabot[bot]Bordapre-commit-ci[bot]
authored
Drop starsessions from App's requirements (#18470)
--------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 665c94c commit 369b990

File tree

3 files changed

+0
-17
lines changed

3 files changed

+0
-17
lines changed

requirements/app/app.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ lightning-cloud == 0.5.57 # Must be pinned to ensure compatibility
22
packaging
33
typing-extensions >=4.4.0, <4.8.0
44
deepdiff >=5.7.0, <6.6.0
5-
starsessions >=1.2.1, <2.0 # strict
65
fsspec[http] >=2022.5.0, <2023.11.0
76
croniter >=1.3.0, <1.5.0 # strict; TODO: for now until we find something more robust.
87
traitlets >=5.3.0, <5.10.0

src/lightning/app/core/api.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,6 @@
5858
from lightning.app.utilities.cloud import is_running_in_cloud
5959
from lightning.app.utilities.component import _context
6060
from lightning.app.utilities.enum import ComponentContext, OpenAPITags
61-
from lightning.app.utilities.imports import _is_starsessions_available
62-
63-
if _is_starsessions_available():
64-
from starsessions import SessionMiddleware
65-
else:
66-
67-
class SessionMiddleware: # type: ignore[no-redef]
68-
pass
69-
7061

7162
# TODO: fixed uuid for now, it will come from the FastAPI session
7263
TEST_SESSION_UUID = "1234"
@@ -175,9 +166,6 @@ class StateUpdate(BaseModel):
175166
allow_headers=["*"],
176167
)
177168

178-
if _is_starsessions_available():
179-
fastapi_service.add_middleware(SessionMiddleware, secret_key="secret", autoload=True) # noqa: S106
180-
181169

182170
# General sequence is:
183171
# * an update is generated in the UI

src/lightning/app/utilities/imports.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,6 @@ def _is_streamlit_tensorboard_available() -> bool:
103103
return module_available("streamlit_tensorboard")
104104

105105

106-
def _is_starsessions_available() -> bool:
107-
return module_available("starsessions")
108-
109-
110106
def _is_gradio_available() -> bool:
111107
return module_available("gradio")
112108

0 commit comments

Comments
 (0)