Skip to content

Commit 36aa4e2

Browse files
carmoccalexierule
authored andcommitted
Cleanup TPU CI script error management (#14389)
1 parent 67ce3eb commit 36aa4e2

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

dockers/tpu-tests/tpu_test_cases.jsonnet

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ local tputests = base.BaseTest {
2121
command: utils.scriptCommand(
2222
|||
2323
source ~/.bashrc
24+
set -e
2425
conda activate lightning
2526
mkdir -p /home/runner/work/pytorch-lightning && cd /home/runner/work/pytorch-lightning
2627
git clone https://github.com/Lightning-AI/lightning.git
@@ -31,21 +32,18 @@ local tputests = base.BaseTest {
3132
git checkout {SHA}
3233
export PACKAGE_NAME=pytorch
3334
export FREEZE_REQUIREMENTS=1
34-
export PL_STANDALONE_TESTS_BATCH_SIZE=1
3535
pip install -e .[test]
3636
echo $KUBE_GOOGLE_CLOUD_TPU_ENDPOINTS
3737
export XRT_TPU_CONFIG="tpu_worker;0;${KUBE_GOOGLE_CLOUD_TPU_ENDPOINTS:7}"
3838
export PL_RUN_TPU_TESTS=1
3939
cd tests/tests_pytorch
40-
set -e
4140
coverage run --source=pytorch_lightning -m pytest -vv --durations=0 ./
4241
echo "\n||| Running standalone tests |||\n"
42+
export PL_STANDALONE_TESTS_BATCH_SIZE=1
4343
bash run_standalone_tests.sh
44-
test_exit_code=$?
4544
echo "\n||| END PYTEST LOGS |||\n"
4645
coverage xml
4746
cat coverage.xml | tr -d '\t'
48-
test $test_exit_code -eq 0
4947
|||
5048
),
5149
};

0 commit comments

Comments
 (0)