fix based on feedback

Author: SkafteNicki

src/lightning/pytorch/utilities/parsing.py

@@ -169,12 +169,6 @@ def save_hyperparameters(
     elif is_dataclass(obj):
         obj_fields = fields(obj)
         init_args = {f.name: getattr(obj, f.name) for f in obj_fields if f.init}
-        if any(not f.init for f in obj_fields):
-            rank_zero_warn(
-                "Detected a dataclass with fields with `init=False`. This is not supported by `save_hyperparameters`"
-                " and will not save those fields in `self.hparams`. Consider removing `init=False` and just"
-                " re-initialize the attributes in the `__post_init__` method of the dataclass."
-            )
     else:
         init_args = {}
 

tests/tests_pytorch/models/test_hparams.py

@@ -895,8 +895,7 @@ def __post_init__(self):
             super().__init__()
             self.save_hyperparameters()
 
-    with pytest.warns(UserWarning, match="Detected a dataclass with fields with `init=False`"):
-        model = DataClassWithInitFalseFieldsModel(33, optional="cocofruit")
+    model = DataClassWithInitFalseFieldsModel(33, optional="cocofruit")
 
     expected_hparams = {"mandatory": 33, "optional": "cocofruit"}
     assert model.hparams == expected_hparams