Skip to content

Commit 4d98d8a

Browse files
committed
added .md
1 parent 675dbed commit 4d98d8a

File tree

7 files changed

+213
-1
lines changed

7 files changed

+213
-1
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ test_tube_exp/
1616
docs/source/pl_examples*.rst
1717
docs/source/pytorch_lightning*.rst
1818
tests/tests/
19-
/docs/source/*.md
2019

2120
# Byte-compiled / optimized / DLL files
2221
__pycache__/
Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
# How to become a core contributor
2+
3+
Thanks for your interest in joining the Lightning team! We’re a rapidly growing project which is poised to become the go-to framework for DL researchers!
4+
We're currently recruiting for a team of 5 core maintainers.
5+
6+
As a core maintainer you will have a strong say in the direction of the project. Big changes will require a majority of maintainers to agree.
7+
8+
### Code of conduct
9+
First and foremost, you'll be evaluated against [these core values](https://github.com/PyTorchLightning/pytorch-lightning/blob/master/.github/CONTRIBUTING.md). Any code we commit or feature we add needs to align with those core values.
10+
11+
### The bar for joining the team
12+
Lightning is being used to solve really hard problems at the top AI labs in the world. As such, the bar for adding team members is extremely high. Candidates must have solid engineering skills, have a good eye for user experience, and must be a power user of Lightning and PyTorch.
13+
14+
With that said, the Lightning team will be diverse and a reflection of an inclusive AI community. You don't have to be an engineer to conntribute! Scientists with great usability intuition and PyTorch ninja skills are welcomed!
15+
16+
### Responsibilities:
17+
The responsibilities mainly revolve around 3 things.
18+
19+
#### Github issues
20+
- Here we want to help users have an amazing experience. These range from questions from new people getting into DL to questions from researchers about doing something esoteric with Lightning
21+
Often, these issues require some sort of bug fix, document clarification or new functionality to be scoped out.
22+
23+
- To become a core member you must resolve at least 10 Github issues which align with the API design goals for Lightning. By the end of these 10 issues I should feel comfortable in the way you answer user questions
24+
Pleasant/helpful tone.
25+
26+
- Can abstract from that issue or bug into functionality that might solve other related issues or makes the platform more flexible.
27+
28+
- Don’t make users feel like they don’t know what they’re doing. We’re here to help and to make everyone’s experience delightful.
29+
30+
#### Pull requests
31+
32+
- Here we need to ensure the code that enters Lightning is high quality. For each PR we need to:
33+
- Make sure code coverage does not decrease
34+
- Documents are updated
35+
- Code is elegant and simple
36+
- Code is NOT overly engineered or hard to read
37+
- Ask yourself, could a non-engineer understand what’s happening here?
38+
- Make sure new tests are written
39+
- Is this NECESSARY for Lightning? There are some PRs which are just purely about adding engineering complexity which have no place in Lightning.
40+
Guidance
41+
- Some other PRs are for people who are wanting to get involved and add something unnecessary. We do want their help though! So don’t approve the PR, but direct them to a Github issue that they might be interested in helping with instead!
42+
- To be considered for core contributor, please review 10 PRs and help the authors land it on master. Once you've finished the review, ping me
43+
for a sanity check. At the end of 10 PRs if your PR reviews are inline with expectations described above, then you can merge PRs on your own going forward,
44+
otherwise we'll do a few more until we're both comfortable :)
45+
46+
#### Project directions
47+
There are some big decisions which the project must make. For these I expect core contributors to have something meaningful to add if it’s their area of expertise.
48+
49+
#### Diversity
50+
Lightning should reflect the broader community it serves. As such we should have scientists/researchers from
51+
different fields contributing!
52+
53+
The first 5 core contributors will fit this profile. Thus if you overlap strongly with experiences and expertise as someone else on the team, you might have to wait until the next set of contributors are added.
54+
55+
#### Summary: Requirements to apply
56+
- Solve 10 Github issues. The goal is to be inline with expectations for solving issues by the last one so you can do them on your own. If not, I might ask you to solve a few more specific ones.
57+
- Do 10 PR reviews. The goal is to be inline with expectations for solving issues by the last one so you can do them on your own. If not, I might ask you to solve a few more specific ones.
58+
59+
If you want to be considered, ping me on gitter and start [tracking your progress here](https://docs.google.com/spreadsheets/d/15D58gp8DvI0Z6qbbYVRuaWioiwzafcP58-UlbuO_CMU/edit?usp=sharing).

docs/source/CODE_OF_CONDUCT.md

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
# Contributor Covenant Code of Conduct
2+
3+
## Our Pledge
4+
5+
In the interest of fostering an open and welcoming environment, we as
6+
contributors and maintainers pledge to making participation in our project and
7+
our community a harassment-free experience for everyone, regardless of age, body
8+
size, disability, ethnicity, sex characteristics, gender identity and expression,
9+
level of experience, education, socio-economic status, nationality, personal
10+
appearance, race, religion, or sexual identity and orientation.
11+
12+
## Our Standards
13+
14+
Examples of behavior that contributes to creating a positive environment
15+
include:
16+
17+
* Using welcoming and inclusive language
18+
* Being respectful of differing viewpoints and experiences
19+
* Gracefully accepting constructive criticism
20+
* Focusing on what is best for the community
21+
* Showing empathy towards other community members
22+
23+
Examples of unacceptable behavior by participants include:
24+
25+
* The use of sexualized language or imagery and unwelcome sexual attention or
26+
advances
27+
* Trolling, insulting/derogatory comments, and personal or political attacks
28+
* Public or private harassment
29+
* Publishing others' private information, such as a physical or electronic
30+
address, without explicit permission
31+
* Other conduct which could reasonably be considered inappropriate in a
32+
professional setting
33+
34+
## Our Responsibilities
35+
36+
Project maintainers are responsible for clarifying the standards of acceptable
37+
behavior and are expected to take appropriate and fair corrective action in
38+
response to any instances of unacceptable behavior.
39+
40+
Project maintainers have the right and responsibility to remove, edit, or
41+
reject comments, commits, code, wiki edits, issues, and other contributions
42+
that are not aligned to this Code of Conduct, or to ban temporarily or
43+
permanently any contributor for other behaviors that they deem inappropriate,
44+
threatening, offensive, or harmful.
45+
46+
## Scope
47+
48+
This Code of Conduct applies both within project spaces and in public spaces
49+
when an individual is representing the project or its community. Examples of
50+
representing a project or community include using an official project e-mail
51+
address, posting via an official social media account, or acting as an appointed
52+
representative at an online or offline event. Representation of a project may be
53+
further defined and clarified by project maintainers.
54+
55+
## Enforcement
56+
57+
Instances of abusive, harassing, or otherwise unacceptable behavior may be
58+
reported by contacting the project team at [email protected]. All
59+
complaints will be reviewed and investigated and will result in a response that
60+
is deemed necessary and appropriate to the circumstances. The project team is
61+
obligated to maintain confidentiality with regard to the reporter of an incident.
62+
Further details of specific enforcement policies may be posted separately.
63+
64+
Project maintainers who do not follow or enforce the Code of Conduct in good
65+
faith may face temporary or permanent repercussions as determined by other
66+
members of the project's leadership.
67+
68+
## Attribution
69+
70+
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
71+
available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
72+
73+
[homepage]: https://www.contributor-covenant.org
74+
75+
For answers to common questions about this code of conduct, see
76+
https://www.contributor-covenant.org/faq

docs/source/CONTRIBUTING.md

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
# Contributing
2+
Welcome to the PyTorch Lightning community! We're building the most advanced research platform on the planet to implement the latest, best practices that the amazing PyTorch team rolls out!
3+
4+
## Main Core Value: One less thing to remember
5+
Simplify the API as much as possible from the user perspective. Any additions or improvements should minimize things the user needs to remember.
6+
7+
For example: One benefit of the validation_step is that the user doesn't have to remember to set the model to .eval(). This avoids all sorts of subtle errors the user could make.
8+
9+
## Lightning Design Principles
10+
We encourage all sorts of contributions you're interested in adding! When coding for lightning, please follow these principles.
11+
#### No PyTorch Interference
12+
We don't want to add any abstractions on top of pure PyTorch. This gives researchers all the control they need without having to learn yet another framework.
13+
14+
#### Simple Internal Code
15+
It's useful for users to look at the code and understand very quickly what's happening. Many users won't be engineers. Thus we need to value clear, simple code over condensed ninja moves. While that's super cool, this isn't the project for that :)
16+
17+
#### Force User Decisions To Best Practices
18+
There are 1,000 ways to do something. However, something eventually becomes standard practice that everyone does. Thus we pick one way of doing it and force everyone to do it this way. A good example is accumulated gradients. There are many ways to implement, we just pick one and force users to use that one. A bad forced decision would be to make users use a specific library to do something.
19+
20+
When something becomes a best practice, we add it to the framework. This likely looks like code in utils or in the model file that everyone keeps adding over and over again across projects. When this happens, bring that code inside the trainer and add a flag for it.
21+
22+
#### Simple External API
23+
What makes sense to you may not make sense to others. Create an issue with an API change suggestion and validate that it makes sense for others. Treat code changes how you treat a startup: validate that it's a needed feature, then add if it makes sense for many people.
24+
25+
#### Backward-compatible API
26+
We all hate updating our deep learning packages because we don't want to refactor a bunch of stuff. In Lightning, we make sure every change we make which could break an API is backwards compatible with good deprecation warnings.
27+
28+
You shouldn't be afraid to upgrade Lightning :)
29+
30+
#### Gain User Trust
31+
As a researcher you can't have any part of your code going wrong. So, make thorough tests that ensure an implementation of a new trick or subbtle change is correct.
32+
33+
#### Interoperability
34+
Have a favorite feature from other libraries like fast.ai or transformers? Those should just work with lightning as well. Grab your favorite model or learning rate scheduler from your favorite library and run it in Lightning.
35+
36+
## Contribution Types
37+
Currently looking for help implementing new features or adding bug fixes.
38+
39+
A lot of good work has already been done in project mechanics (requirements.txt, setup.py, pep8, badges, ci, etc...) we're in a good state there thanks to all the early contributors (even pre-beta release)!
40+
41+
## Bug Fixes:
42+
1. Submit a github issue.
43+
2. Fix it.
44+
3. Submit a PR!
45+
46+
## New Features:
47+
1. Submit a github issue.
48+
2. We'll agree on the feature scope.
49+
3. Submit a PR! (with updated docs and tests 🙃).
50+
51+
## Coding Styleguide
52+
1. Test the code with flake8.
53+
2. Use f-strings.
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# Before submitting
2+
3+
- [ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
4+
- [ ] Did you read the [contributor guideline](https://github.com/PyTorchLightning/pytorch-lightning/blob/master/.github/CONTRIBUTING.md)?
5+
- [ ] Did you make sure to update the docs?
6+
- [ ] Did you write any new necessary tests?
7+
8+
## What does this PR do?
9+
Fixes # (issue).
10+
11+
## PR review
12+
Anyone in the community is free to review the PR once the tests have passed.
13+
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
14+
15+
## Did you have fun?
16+
Make sure you had fun coding 🙃

docs/source/_templates/theme_variables.jinja

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
'github': 'https://github.com/PytorchLightning/pytorch-lightning',
33
'github_issues': 'https://github.com/PytorchLightning/pytorch-lightning/issues',
44
'contributing': 'https://github.com/PytorchLightning/pytorch-lightning/blob/master/CONTRIBUTING.md',
5+
'governance': 'https://github.com/PytorchLightning/pytorch-lightning/blob/master/governance.md',
56
'docs': 'https://pytorch-lightning.rtfd.io/en/latest',
67
'twitter': 'https://twitter.com/PyTorchLightnin',
78
'discuss': 'https://discuss.pytorch.org',

docs/source/governance.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# Pytorch Lightning Governance | Persons of interest
2+
3+
### Maintainers
4+
- William Falcon ([williamFalcon](https://github.com/williamFalcon))
5+
- Jirka Borovek ([Borda](https://github.com/Borda))
6+
- Nick Eggert ([neggert](https://github.com/neggert))
7+
- Jeff Ling ([jeffling](https://github.com/jeffling))
8+
- Tullie Murrell ([tullie](https://github.com/tullie))

0 commit comments

Comments
 (0)