Skip to content

Commit 52695b0

Browse files
Fix mypy check failure and val_check_interval initialization in case of time based validation.
1 parent 44e88a4 commit 52695b0

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/lightning/pytorch/trainer/setup.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,6 @@ def _init_debugging_flags(
9090
trainer._val_check_time_interval = None # default
9191
if isinstance(val_check_interval, (str, dict, timedelta)):
9292
trainer._val_check_time_interval = _parse_time_interval_seconds(val_check_interval)
93-
# Keep the numeric scheduler neutral; loops should check the time-based attribute.
94-
trainer.val_check_interval = 1.0
9593
else:
9694
trainer.val_check_interval = _determine_batch_limits(val_check_interval, "val_check_interval")
9795

src/lightning/pytorch/trainer/trainer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ def __init__(
498498
self._logger_connector.on_trainer_init(logger, log_every_n_steps)
499499

500500
# init debugging flags
501-
self.val_check_batch: Union[int, float]
501+
self.val_check_batch: Optional[Union[int, float]] = None
502502
self.val_check_interval: Union[int, float]
503503
self.num_sanity_val_steps: Union[int, float]
504504
self.limit_train_batches: Union[int, float]

0 commit comments

Comments
 (0)