Skip to content

Commit 5c0118f

Browse files
committed
ddp pickle
1 parent 013fd98 commit 5c0118f

File tree

3 files changed

+22
-0
lines changed

3 files changed

+22
-0
lines changed

tests/callbacks/test_callbacks.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,15 @@ def training_step(self, *args, **kwargs):
240240
assert trainer.current_epoch < trainer.max_epochs
241241

242242

243+
def test_pickling(tmpdir):
244+
import pickle
245+
early_stopping = EarlyStopping()
246+
ckpt = ModelCheckpoint(tmpdir)
247+
248+
pickle.dumps(ckpt)
249+
pickle.dumps(early_stopping)
250+
251+
243252
def test_model_checkpoint_with_non_string_input(tmpdir):
244253
""" Test that None in checkpoint callback is valid and that chkp_path is
245254
set correctly """

tests/loggers/test_all.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ def log_metrics(self, metrics, step):
7777
# WandbLogger, # TODO: add this one
7878
])
7979
def test_loggers_pickle(tmpdir, monkeypatch, logger_class):
80+
import pickle
81+
8082
"""Verify that pickling trainer with logger works."""
8183
tutils.reset_seed()
8284

@@ -88,6 +90,9 @@ def test_loggers_pickle(tmpdir, monkeypatch, logger_class):
8890
logger_args = _get_logger_args(logger_class, tmpdir)
8991
logger = logger_class(**logger_args)
9092

93+
# test pickling loggers
94+
pickle.dumps(logger)
95+
9196
trainer = Trainer(
9297
max_epochs=1,
9398
logger=logger

tests/trainer/test_trainer.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,14 @@
2424
LightTestDataloader,
2525
LightValidationMixin,
2626
)
27+
from tests.base import TestModelBase
28+
29+
30+
def test_model_pickle(tmpdir):
31+
import pickle
32+
33+
model = TestModelBase()
34+
pickle.dumps(model)
2735

2836

2937
def test_hparams_save_load(tmpdir):

0 commit comments

Comments
 (0)