Skip to content

Commit 669ecff

Browse files
rename integrations (#16312)
* rename integrations * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * name * Artifact Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 5a9b5e3 commit 669ecff

38 files changed

+51
-63
lines changed

.azure/app-cloud-e2e.yml

Lines changed: 19 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ pr:
3131
- ".azure/app-cloud-e2e.yml"
3232
- "src/lightning_app/**"
3333
- "requirements/app/**"
34-
- "tests/tests_examples_app/**"
34+
- "tests/integrations_app_examples/**"
3535
- "setup.py"
3636
exclude:
3737
- "requirements/*/docs.txt"
@@ -48,8 +48,8 @@ variables:
4848
value: ./videos
4949

5050
jobs:
51-
- job: App_cloud_e2e_testing
52-
pool: azure-cpus
51+
- job: App_e2e_cloud
52+
pool: "azure-cpus"
5353
container:
5454
image: mcr.microsoft.com/playwright/python:v1.28.0-focal
5555
options: "--shm-size=4gb"
@@ -98,6 +98,17 @@ jobs:
9898
# values: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml#workspace
9999
workspace:
100100
clean: all
101+
variables:
102+
HEADLESS: '1'
103+
PACKAGE_LIGHTNING: '1'
104+
CLOUD: '1'
105+
VIDEO_LOCATION: $(video_artifact_dir)
106+
PR_NUMBER: $(local_id)
107+
TEST_APP_NAME: $(name)
108+
TEST_APP_FOLDER: $(dir)
109+
HAR_LOCATION: './artifacts/hars'
110+
SLOW_MO: '50'
111+
LIGHTNING_DEBUG: '1'
101112
steps:
102113

103114
- script: echo '##vso[task.setvariable variable=local_id]$(System.PullRequest.PullRequestNumber)'
@@ -134,13 +145,6 @@ jobs:
134145
condition: eq(variables['name'], 'quick_start')
135146
displayName: 'Clone Quick start Repo'
136147
137-
# - bash: |
138-
# rm -rf examples/app_template_jupyterlab || true
139-
# git clone https://github.com/Lightning-AI/LAI-lightning-template-jupyterlab-App examples/app_template_jupyterlab
140-
# cp examples/app_template_jupyterlab/tests/test_template_jupyterlab.py tests/tests_examples_app/test_template_jupyterlab.py
141-
# condition: eq(variables['name'], 'template_jupyterlab')
142-
# displayName: 'Clone Template Jupyter Lab Repo'
143-
144148
- bash: |
145149
rm -rf examples/app_template_react_ui || true
146150
git clone https://github.com/Lightning-AI/lightning-template-react examples/app_template_react_ui
@@ -163,35 +167,25 @@ jobs:
163167
displayName: 'List pip dependency'
164168
165169
- bash: |
166-
mkdir -p ${VIDEO_LOCATION}
167170
ls -l examples/${TEST_APP_NAME}
168-
ls -l tests/tests_examples_app/public
169-
python -m pytest tests/tests_examples_app/${TEST_APP_FOLDER}/test_${TEST_APP_NAME}.py::test_${TEST_APP_NAME}_example_cloud \
171+
python -m pytest ${TEST_FILE}::test_${TEST_APP_NAME}_example_cloud \
170172
--timeout=540 --capture=no -v --color=yes
171173
env:
172-
HEADLESS: '1'
173-
PACKAGE_LIGHTNING: '1'
174-
CLOUD: '1'
175-
VIDEO_LOCATION: $(video_artifact_dir)
176-
PR_NUMBER: $(local_id)
177-
TEST_APP_NAME: $(name)
178-
TEST_APP_FOLDER: $(dir)
179-
HAR_LOCATION: './artifacts/hars'
180-
SLOW_MO: '50'
174+
TEST_FILE: tests/integrations_app_examples/$(TEST_APP_FOLDER)/test_$(TEST_APP_NAME).py
181175
#LAI_USER: $(LAI_USER) # for STAGING
182176
#LAI_PASS: $(LAI_PASS) # for STAGING
183177
LIGHTNING_USER_ID: $(LIGHTNING_USER_ID_PROD)
184178
LIGHTNING_API_KEY: $(LIGHTNING_API_KEY_PROD)
185179
LIGHTNING_USERNAME: $(LIGHTNING_USERNAME)
186180
LIGHTNING_CLOUD_URL: $(LIGHTNING_CLOUD_URL_PROD)
187-
LIGHTNING_DEBUG: '1'
188181
displayName: 'Run the tests'
189182
190183
- task: PublishPipelineArtifact@1
191184
condition: failed()
192185
inputs:
193-
path: $(video_artifact_dir)
186+
path: "$(video_artifact_dir)/$(name)"
194187
artifactName: $(name)
188+
publishLocation: 'pipeline'
195189
displayName: 'Publish videos'
196190

197191
- bash: |
@@ -204,11 +198,5 @@ jobs:
204198
LIGHTNING_API_KEY: $(LIGHTNING_API_KEY_PROD)
205199
LIGHTNING_USERNAME: $(LIGHTNING_USERNAME)
206200
LIGHTNING_CLOUD_URL: $(LIGHTNING_CLOUD_URL_PROD)
207-
PR_NUMBER: $(local_id)
208-
TEST_APP_NAME: $(name)
209-
TEST_APP_FOLDER: $(dir)
210-
# GRID_USER_ID: $(LIGHTNING_USER_ID) # TODO: clarify the meaning
211-
# GRID_USER_KEY: $(LIGHTNING_API_KEY) # TODO: clarify the meaning
212-
# GRID_URL: $(LIGHTNING_CLOUD_URL)
213-
# _GRID_USERNAME: $(LIGHTNING_USERNAME)
201+
timeoutInMinutes: "3"
214202
displayName: 'Clean Previous Apps'

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
# Lightning App
4646
/src/lightning_app @tchaton @lantiga @awaelchli @hhsecond @ethanwharris
4747
/tests/tests_app @tchaton @lantiga @awaelchli @hhsecond @ethanwharris
48-
/tests/tests_examples_app @tchaton @lantiga @awaelchli @hhsecond @ethanwharris
48+
/tests/integrations_app_examples @tchaton @lantiga @awaelchli @hhsecond @ethanwharris
4949
/examples/app_* @tchaton @lantiga @awaelchli @hhsecond @ethanwharris
5050

5151
/.github/CODEOWNERS @williamfalcon

.github/checkgroup.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ subprojects:
247247
- ".actions/**"
248248
- ".github/workflows/ci-examples-app.yml"
249249
- "src/lightning_app/**"
250-
- "tests/tests_examples_app/**"
250+
- "tests/integrations_app_examples/**"
251251
- "examples/app_*/**"
252252
- "requirements/app/**"
253253
- "setup.py"
@@ -271,7 +271,7 @@ subprojects:
271271
- ".azure/app-cloud-e2e.yml"
272272
- "src/lightning_app/**"
273273
- "requirements/app/**"
274-
- "tests/tests_examples_app/**"
274+
- "tests/integrations_app_examples/**"
275275
- "setup.py"
276276
- "!requirements/*/docs.txt"
277277
- "!*.md"

.github/labeler.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ app:
55
all: ['!src/pytorch_lightning/**/*', '!tests/tests_pytorch/**/*', '!docs/source-pytorch/**/*', '!requirements/pytorch/*']
66
- any: ['tests/tests_app/**/*']
77
all: ['!src/pytorch_lightning/**/*', '!tests/tests_pytorch/**/*', '!docs/source-pytorch/**/*', '!requirements/pytorch/*']
8-
- any: ['tests/tests_examples_app/**/*']
8+
- any: ['tests/integrations_app_examples/**/*']
99
all: ['!src/pytorch_lightning/**/*', '!tests/tests_pytorch/**/*', '!docs/source-pytorch/**/*', '!requirements/pytorch/*']
1010
- any: ['examples/app_*/**/*']
1111
all: ['!src/pytorch_lightning/**/*', '!tests/tests_pytorch/**/*', '!docs/source-pytorch/**/*', '!requirements/pytorch/*']
@@ -16,12 +16,12 @@ app:
1616

1717
pl:
1818
- any: ['src/pytorch_lightning/**/*']
19-
all: ['!src/lightning/**/*', '!src/lightning_app/**/*', '!tests/tests_app/**/*', '!tests/tests_examples_app/**/*', '!docs/source-app/**/*', '!requirements/app/*']
19+
all: ['!src/lightning/**/*', '!src/lightning_app/**/*', '!tests/tests_app/**/*', '!tests/integrations_app_examples/**/*', '!docs/source-app/**/*', '!requirements/app/*']
2020
- any: ['examples/*pl_*/**/*']
21-
all: ['!src/lightning/**/*', '!src/lightning_app/**/*', '!tests/tests_app/**/*', '!tests/tests_examples_app/**/*', '!docs/source-app/**/*', '!requirements/app/*']
21+
all: ['!src/lightning/**/*', '!src/lightning_app/**/*', '!tests/tests_app/**/*', '!tests/integrations_app_examples/**/*', '!docs/source-app/**/*', '!requirements/app/*']
2222
- any: ['tests/tests_pytorch/**/*']
23-
all: ['!src/lightning/**/*', '!src/lightning_app/**/*', '!tests/tests_app/**/*', '!tests/tests_examples_app/**/*', '!docs/source-app/**/*', '!requirements/app/*']
23+
all: ['!src/lightning/**/*', '!src/lightning_app/**/*', '!tests/tests_app/**/*', '!tests/integrations_app_examples/**/*', '!docs/source-app/**/*', '!requirements/app/*']
2424
- any: ['docs/source-pytorch/**/*']
25-
all: ['!src/lightning/**/*', '!src/lightning_app/**/*', '!tests/tests_app/**/*', '!tests/tests_examples_app/**/*', '!docs/source-app/**/*', '!requirements/app/*']
25+
all: ['!src/lightning/**/*', '!src/lightning_app/**/*', '!tests/tests_app/**/*', '!tests/integrations_app_examples/**/*', '!docs/source-app/**/*', '!requirements/app/*']
2626
- any: ['requirements/pytorch/*']
27-
all: ['!src/lightning/**/*', '!src/lightning_app/**/*', '!tests/tests_app/**/*', '!tests/tests_examples_app/**/*', '!docs/source-app/**/*', '!requirements/app/*']
27+
all: ['!src/lightning/**/*', '!src/lightning_app/**/*', '!tests/tests_app/**/*', '!tests/integrations_app_examples/**/*', '!docs/source-app/**/*', '!requirements/app/*']

.github/workflows/ci-examples-app.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111
- ".actions/**"
1212
- ".github/workflows/ci-examples-app.yml"
1313
- "src/lightning_app/**"
14-
- "tests/tests_examples_app/**"
14+
- "tests/integrations_app_examples/**"
1515
- "examples/app_*/**"
1616
- "requirements/app/**"
1717
- "setup.py"
@@ -114,7 +114,7 @@ jobs:
114114
PYTEST_ARTIFACT: results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}.xml
115115
run: |
116116
python -m coverage run --source ${COVERAGE_SCOPE} \
117-
-m pytest -m "not cloud" tests_examples_app \
117+
-m pytest -m "not cloud" integrations_app_examples \
118118
--timeout=300 --durations=0 -vvvv \
119119
--junitxml=$PYTEST_ARTIFACT
120120
File renamed without changes.

tests/tests_examples_app/apps/collect_failures/__init__.py renamed to tests/integrations_app_examples/apps/collect_failures/__init__.py

File renamed without changes.

tests/tests_examples_app/apps/collect_failures/app.py renamed to tests/integrations_app_examples/apps/collect_failures/app.py

File renamed without changes.

tests/tests_examples_app/apps/collect_failures/requirements.txt renamed to tests/integrations_app_examples/apps/collect_failures/requirements.txt

File renamed without changes.

tests/tests_examples_app/apps/core_features_app/__init__.py renamed to tests/integrations_app_examples/apps/core_features_app/__init__.py

File renamed without changes.

0 commit comments

Comments
 (0)