Skip to content

Commit 710cac4

Browse files
authored
Make fsspec requirement the same across subpackages (#19085)
1 parent 9bcb983 commit 710cac4

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

requirements/app/app.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ packaging
33
typing-extensions >=4.4.0, <4.8.0
44
deepdiff >=5.7.0, <6.6.0
55
starsessions >=1.2.1, <2.0 # strict
6-
fsspec >=2022.5.0, <2023.11.0
6+
fsspec[http] >=2022.5.0, <2023.11.0
77
croniter >=1.3.0, <1.5.0 # strict; TODO: for now until we find something more robust.
88
traitlets >=5.3.0, <5.10.0
99
arrow >=1.2.0, <1.3.0

requirements/data/cloud.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# NOTE: the upper bound for the package version is only set for CI stability, and it is dropped while installing this package
22
# in case you want to preserve/enforce restrictions on the latest compatible version, add "strict" as an in-line comment
33

4-
fsspec[http] >2021.06.0, <2023.11.0
4+
fsspec[http] >=2022.5.0, <2023.11.0
55
s3fs >=2022.5.0, <2023.7.0

requirements/fabric/base.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
numpy >=1.17.2, <1.27.0
55
torch >=1.12.0, <2.2.0
6-
fsspec[http]>2021.06.0, <2023.11.0
6+
fsspec[http] >=2022.5.0, <2023.11.0
77
packaging >=20.0, <=23.1
88
typing-extensions >=4.4.0, <4.8.0
99
lightning-utilities >=0.8.0, <0.10.0

requirements/pytorch/base.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ numpy >=1.17.2, <1.27.0
55
torch >=1.12.0, <2.2.0
66
tqdm >=4.57.0, <4.67.0
77
PyYAML >=5.4, <6.1.0
8-
fsspec[http] >2021.06.0, <2023.11.0
8+
fsspec[http] >=2022.5.0, <2023.11.0
99
torchmetrics >=0.7.0, <1.3.0 # needed for using fixed compare_version
1010
packaging >=20.0, <=23.1
1111
typing-extensions >=4.4.0, <4.8.0

src/lightning/pytorch/trainer/configuration_validator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ def __warn_dataloader_iter_limitations(model: "pl.LightningModule") -> None:
164164
"You are using the `dataloader_iter` step flavor. If you consume the iterator more than once per step, the"
165165
" `batch_idx` argument in any hook that takes it will not match with the batch index of the last batch"
166166
" consumed. This might have unforeseen effects on callbacks or code that expects to get the correct index."
167-
" This will also no work well with gradient accumulation. This feature is very experimental and subject to"
167+
" This will also not work well with gradient accumulation. This feature is very experimental and subject to"
168168
" change. Here be dragons.",
169169
category=PossibleUserWarning,
170170
)

0 commit comments

Comments
 (0)