Skip to content

Commit 73d8091

Browse files
committed
set min in tests
1 parent 6207476 commit 73d8091

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

tests/tests_fabric/test_connector.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def __instancecheck__(self, instance):
7777
@pytest.mark.parametrize(
7878
("accelerator", "devices"), [("tpu", "auto"), ("tpu", 1), ("tpu", [1]), ("tpu", 8), ("auto", 1), ("auto", 8)]
7979
)
80-
@RunIf(min_python="3.9") # mocking issue
80+
@RunIf(min_python="3.10") # mocking issue
8181
def test_accelerator_choice_tpu(accelerator, devices, tpu_available, monkeypatch):
8282
monkeypatch.setattr(torch, "device", DeviceMock())
8383

@@ -1031,7 +1031,7 @@ def get_defaults(cls):
10311031

10321032

10331033
@pytest.mark.parametrize("is_interactive", [False, True])
1034-
@RunIf(min_python="3.9") # mocking issue
1034+
@RunIf(min_python="3.10") # mocking issue
10351035
def test_connector_auto_selection(monkeypatch, is_interactive):
10361036
no_cuda = mock.patch("lightning.fabric.accelerators.cuda.num_cuda_devices", return_value=0)
10371037
single_cuda = mock.patch("lightning.fabric.accelerators.cuda.num_cuda_devices", return_value=1)

tests/tests_fabric/utilities/test_imports.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def test_import_deepspeed_lazily():
7171
assert subprocess.call([sys.executable, "-c", code]) == 0
7272

7373

74-
@RunIf(min_python="3.9")
74+
@RunIf(min_python="3.10")
7575
def test_import_lightning_multiprocessing_start_method_not_set():
7676
"""Regression test for avoiding the lightning import to set the multiprocessing context."""
7777
package_name = "lightning_fabric" if "lightning.fabric" == "lightning_fabric" else "lightning"

tests/tests_pytorch/accelerators/test_xla.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ def test_warning_if_tpus_not_used(tpu_available):
310310
("2,", [2]),
311311
],
312312
)
313-
@RunIf(min_python="3.9") # mocking issue
313+
@RunIf(min_python="3.10") # mocking issue
314314
def test_trainer_config_device_ids(devices, expected_device_ids, tpu_available, monkeypatch):
315315
monkeypatch.setattr(lightning.fabric.accelerators.xla, "_using_pjrt", lambda: True)
316316

tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
@pytest.mark.parametrize(
6666
("accelerator", "devices"), [("tpu", "auto"), ("tpu", 1), ("tpu", [1]), ("tpu", 8), ("auto", 1), ("auto", 8)]
6767
)
68-
@RunIf(min_python="3.9") # mocking issue
68+
@RunIf(min_python="3.10") # mocking issue
6969
def test_accelerator_choice_tpu(accelerator, devices, tpu_available, monkeypatch):
7070
monkeypatch.setattr(torch, "device", DeviceMock())
7171
if _IS_WINDOWS:
@@ -736,7 +736,7 @@ def test_gpu_accelerator_backend_choice_cuda(cuda_count_1):
736736
assert isinstance(trainer.accelerator, CUDAAccelerator)
737737

738738

739-
@RunIf(min_python="3.9") # mocking issue
739+
@RunIf(min_python="3.10") # mocking issue
740740
def test_gpu_accelerator_backend_choice_mps(mps_count_1, cuda_count_0):
741741
trainer = Trainer(accelerator="gpu")
742742
assert trainer._accelerator_connector._accelerator_flag == "mps"
@@ -809,7 +809,7 @@ def test_connector_with_tpu_accelerator_instance(tpu_available, monkeypatch):
809809

810810

811811
@pytest.mark.parametrize("is_interactive", [False, True])
812-
@RunIf(min_python="3.9") # mocking issue
812+
@RunIf(min_python="3.10") # mocking issue
813813
def test_connector_auto_selection(monkeypatch, is_interactive):
814814
import lightning.fabric # avoid breakage with standalone package
815815

tests/tests_pytorch/utilities/test_imports.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ def test_import_deepspeed_lazily():
165165
assert subprocess.call([sys.executable, "-c", code]) == 0
166166

167167

168-
@RunIf(min_python="3.9")
168+
@RunIf(min_python="3.10")
169169
def test_import_lightning_multiprocessing_start_method_not_set():
170170
"""Regression test for avoiding the lightning import to set the multiprocessing context."""
171171
package_name = "pytorch_lightning" if "lightning.pytorch" == "pytorch_lightning" else "lightning"

0 commit comments

Comments
 (0)