Skip to content

Commit 7a21166

Browse files
Bordalantiga
authored andcommitted
tests: marking some flakiness (#17849)
(cherry picked from commit ba943e3)
1 parent 4762e30 commit 7a21166

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

.github/workflows/ci-examples-app.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ jobs:
119119
run: |
120120
python -m coverage run --source ${{ env.COVERAGE_SCOPE }} \
121121
-m pytest -m "not cloud" integrations_app \
122-
--timeout=300 --durations=0 -vvvv
122+
--timeout=120 --durations=0 -vvvv
123123
124124
- name: Statistics
125125
if: success()

.github/workflows/ci-tests-app.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,7 @@ jobs:
125125
AWS_DEFAULT_REGION: us-east-1
126126
run: |
127127
python -m coverage run --source ${{ env.COVERAGE_SCOPE }} \
128-
-m pytest -m "not cloud" tests_app \
129-
--timeout=300 -vvvv --durations=50
128+
-m pytest -m "not cloud" tests_app --timeout=120 -vvvv --durations=50
130129
131130
- name: Statistics
132131
if: success()

tests/tests_app/utilities/test_proxies.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ def proxy_setattr():
7676
],
7777
)
7878
@mock.patch("lightning.app.utilities.proxies._Copier", MagicMock())
79+
@pytest.mark.flaky(reruns=3)
7980
@pytest.mark.xfail(sys.platform == "win32", strict=False, reason="Fix this on Windows") # TODO @ethanwharris
8081
def test_work_runner(parallel, cache_calls, *_):
8182
"""This test validates the `WorkRunner` runs the work.run method and properly populates the `delta_queue`,

tests/tests_pytorch/utilities/test_all_gather_grad.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
# limitations under the License.
1414

1515
import numpy as np
16+
import pytest
1617
import torch
1718

1819
from lightning.pytorch import Trainer
@@ -45,6 +46,7 @@ def all_gather_ddp_spawn_fn(strategy):
4546

4647

4748
@RunIf(skip_windows=True)
49+
@pytest.mark.flaky(reruns=3)
4850
def test_all_gather_ddp_spawn():
4951
spawn_launch(all_gather_ddp_spawn_fn, [torch.device("cpu")] * 3)
5052

0 commit comments

Comments
 (0)