Fixes app CLI tests by checking for the dynamically assigned port (#16283)

* Fixes app CLI tests by checking for the dynamically assigned port.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Noha Alon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 3 people

tests/tests_app/cli/test_run_app.py

@@ -8,6 +8,7 @@
 from click.testing import CliRunner
 from tests_app import _PROJECT_ROOT
 
+import lightning_app.core.constants as constants
 from lightning_app import LightningApp
 from lightning_app.cli.lightning_cli import _run_app, run_app
 from lightning_app.runners.runtime_type import RuntimeType
@@ -45,7 +46,11 @@ def _lightning_app_run_and_logging(self, *args, **kwargs):
             )
             # capture logs.
             if open_ui:
-                lauch_mock.assert_called_with("http://127.0.0.1:7501/view")
+
+                # Get the designated port
+                port = constants.APP_SERVER_PORT
+
+                lauch_mock.assert_called_with(f"http://127.0.0.1:{port}/view")
             else:
                 lauch_mock.assert_not_called()
         assert result.exit_code == 0
@@ -99,6 +104,10 @@ def test_lightning_run_app_cloud(mock_dispatch: mock.MagicMock, open_ui, caplog,
             run_app_comment_commands=False,
             enable_basic_auth="",
         )
+
+        # Get the designated port
+        port = constants.APP_SERVER_PORT
+
     # capture logs.
     # TODO(yurij): refactor the test, check if the actual HTTP request is being sent and that the proper admin
     #  page is being opened
@@ -115,7 +124,7 @@ def test_lightning_run_app_cloud(mock_dispatch: mock.MagicMock, open_ui, caplog,
         cluster_id="",
         run_app_comment_commands=False,
         enable_basic_auth="",
-        port=7501,
+        port=port,
     )
 
 
@@ -145,6 +154,10 @@ def test_lightning_run_app_cloud_with_run_app_commands(mock_dispatch: mock.Magic
             run_app_comment_commands=True,
             enable_basic_auth="",
         )
+
+        # Get the designated port
+        port = constants.APP_SERVER_PORT
+
     # capture logs.
     # TODO(yurij): refactor the test, check if the actual HTTP request is being sent and that the proper admin
     #  page is being opened
@@ -161,7 +174,7 @@ def test_lightning_run_app_cloud_with_run_app_commands(mock_dispatch: mock.Magic
         cluster_id="",
         run_app_comment_commands=True,
         enable_basic_auth="",
-        port=7501,
+        port=port,
     )
 
 
@@ -211,6 +224,9 @@ def test_lightning_run_app_enable_basic_auth_passed(mock_dispatch: mock.MagicMoc
             enable_basic_auth="username:password",
         )
 
+        # Get the designated port
+        port = constants.APP_SERVER_PORT
+
     mock_dispatch.assert_called_with(
         Path(os.path.join(_PROJECT_ROOT, "tests/tests_app/core/scripts/app_metadata.py")),
         RuntimeType.CLOUD,
@@ -224,5 +240,5 @@ def test_lightning_run_app_enable_basic_auth_passed(mock_dispatch: mock.MagicMoc
         cluster_id="",
         run_app_comment_commands=False,
         enable_basic_auth="username:password",
-        port=7501,
+        port=port,
     )