Skip to content

Commit 7ee0994

Browse files
Bordaakihironitta
andauthored
CI: Upload video artifacts from e2e tests (#14467)
* CI: try upload e2e Artifacts * Apply suggestions from code review Co-authored-by: Akihiro Nitta <[email protected]>
1 parent 93a6cff commit 7ee0994

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

.azure/app-cloud-e2e.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ variables:
4040
value: $(Pipeline.Workspace)/.pip
4141
- name: local_id
4242
value: $(Build.BuildId)
43+
- name: video_artifact_dir
44+
value: ./videos
4345

4446
jobs:
4547
- job: App_cloud_e2e_testing
@@ -86,6 +88,7 @@ jobs:
8688

8789
- bash: |
8890
whoami
91+
mkdir -p $(video_artifact_dir)
8992
printf "local id: $(local_id)\n"
9093
python --version
9194
pip --version
@@ -150,7 +153,7 @@ jobs:
150153
HEADLESS: '1'
151154
PACKAGE_LIGHTNING: '1'
152155
CLOUD: '1'
153-
VIDEO_LOCATION: '$(Build.ArtifactStagingDirectory)/videos'
156+
VIDEO_LOCATION: $(video_artifact_dir)
154157
PR_NUMBER: $(local_id)
155158
TEST_APP_NAME: $(name)
156159
HAR_LOCATION: './artifacts/hars'
@@ -164,10 +167,12 @@ jobs:
164167
LIGHTNING_DEBUG: '1'
165168
displayName: 'Run the tests'
166169
167-
- publish: '$(Build.ArtifactStagingDirectory)/videos'
170+
- task: PublishPipelineArtifact@1
168171
condition: failed()
172+
inputs:
173+
path: $(video_artifact_dir)
174+
artifactName: $(name)
169175
displayName: 'Publish videos'
170-
artifact: $(name)
171176

172177
- bash: |
173178
time python -c "from lightning.app import testing; testing.delete_cloud_lightning_apps()"

.github/workflows/ci-schema.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,8 @@ on:
88

99
jobs:
1010
check:
11-
uses: Lightning-AI/devtools/.github/workflows/[email protected]
11+
uses: Lightning-AI/utilities/.github/workflows/[email protected]
12+
with:
13+
# skip azure due to the wrong schema file by MSFT
14+
# https://github.com/Lightning-AI/lightning-flash/pull/1455#issuecomment-1244793607
15+
azure-dir: ''

0 commit comments

Comments
 (0)