Skip to content

Commit 811d37b

Browse files
authored
Update removal version of argparse_utils.py from 1.4 to 2.0 for backwards compatibility (#9162)
1 parent e133061 commit 811d37b

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
158158
- Deprecated the `TestTubeLogger` ([#9065](https://github.com/PyTorchLightning/pytorch-lightning/pull/9065))
159159

160160

161+
- Updated deprecation of `argparse_utils.py` from removal in 1.4 to 2.0 ([#9162](https://github.com/PyTorchLightning/pytorch-lightning/pull/9162))
162+
163+
164+
161165
### Removed
162166

163167
- Removed deprecated `metrics` ([#8586](https://github.com/PyTorchLightning/pytorch-lightning/pull/8586/))

pytorch_lightning/utilities/argparse_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from pytorch_lightning.utilities import rank_zero_deprecation
22

3-
rank_zero_deprecation("`argparse_utils` package has been renamed to `argparse` since v1.2 and will be removed in v1.4")
3+
rank_zero_deprecation("`argparse_utils` package has been renamed to `argparse` since v1.2 and will be removed in v2.0")
44

55
# for backward compatibility with old checkpoints (versions < 1.2.0)
66
# that need to be able to unpickle the function from the checkpoint

tests/deprecated_api/test_remove_1-4.py renamed to tests/deprecated_api/test_remove_2-0.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from tests.deprecated_api import _soft_unimport_module
1919

2020

21-
def test_v1_4_0_deprecated_imports():
21+
def test_v2_0_0_deprecated_imports():
2222
_soft_unimport_module("pytorch_lightning.utilities.argparse_utils")
23-
with pytest.deprecated_call(match="will be removed in v1.4"):
23+
with pytest.deprecated_call(match="will be removed in v2.0"):
2424
from pytorch_lightning.utilities.argparse_utils import _gpus_arg_default # noqa: F401

0 commit comments

Comments
 (0)