release 2.1.4

Author: awaelchli

.actions/assistant.py

@@ -234,7 +234,7 @@ def _download_frontend(pkg_path: str, version: str = "v0.0.0"):
         response = urllib.request.urlopen(frontend_release_url)
 
         file = tarfile.open(fileobj=response, mode="r|gz")
-        file.extractall(path=download_dir)
+        file.extractall(path=download_dir)  # noqa: S202
 
         shutil.move(download_dir, frontend_dir)
         print("The Lightning UI has successfully been downloaded!")
@@ -457,7 +457,7 @@ def pull_docs_files(
                 raise RuntimeError(f"Requesting file '{zip_url}' does not exist or it is just unavailable.")
 
             with zipfile.ZipFile(zip_file, "r") as zip_ref:
-                zip_ref.extractall(tmp)
+                zip_ref.extractall(tmp)  # noqa: S202
 
             zip_dirs = [d for d in glob.glob(os.path.join(tmp, "*")) if os.path.isdir(d)]
             # check that the extracted archive has only repo folder

docs/source-pytorch/extensions/strategy.rst

@@ -77,7 +77,7 @@ The below table lists all relevant strategies available in Lightning with their
      - Strategy for multi-process single-device training on one or multiple nodes. :ref:`Learn more. <accelerators/gpu_intermediate:Distributed Data Parallel>`
    * - ddp_spawn
      - :class:`~lightning.pytorch.strategies.DDPStrategy`
-     - Same as "ddp" but launches processes using :func:`torch.multiprocessing.spawn` method and joins processes after training finishes. :ref:`Learn more. <accelerators/gpu_intermediate:Distributed Data Parallel Spawn>`
+     - Same as "ddp" but launches processes using ``torch.multiprocessing.spawn`` method and joins processes after training finishes. :ref:`Learn more. <accelerators/gpu_intermediate:Distributed Data Parallel Spawn>`
    * - deepspeed
      - :class:`~lightning.pytorch.strategies.DeepSpeedStrategy`
      - Provides capabilities to run training using the DeepSpeed library, with training optimizations for large billion parameter models. :doc:`Learn more. <../advanced/model_parallel/deepspeed>`

examples/app/hpo/utils.py

@@ -48,7 +48,7 @@ def extract_tarfile(file_path: str, extract_path: str, mode: str):
     if ".zip" in local_filename:
         if os.path.exists(local_filename):
             with zipfile.ZipFile(local_filename, "r") as zip_ref:
-                zip_ref.extractall(path)
+                zip_ref.extractall(path)  # noqa: S202
     elif local_filename.endswith(".tar.gz") or local_filename.endswith(".tgz"):
         extract_tarfile(local_filename, path, "r:gz")
     elif local_filename.endswith(".tar.bz2") or local_filename.endswith(".tbz"):

pyproject.toml

@@ -79,6 +79,7 @@ ignore-init-module-imports = true
 ".actions/*" = ["S101", "S310"]
 "setup.py" = ["S101"]
 "examples/**" = [
+    "F841",  # Local variable is assigned to but never used
     "S101",  # Use of `assert` detected
     "S113",  # todo: Probable use of requests call without
     "S104",  # Possible binding to all interface
@@ -88,6 +89,7 @@ ignore-init-module-imports = true
     "S108",  # Probable insecure usage of temporary file or directory: "/tmp/data/MNIST"
 ]
 "src/**" = [
+    "F841",  # Local variable is assigned to but never used
     "S101",  # todo: Use of `assert` detected
     "S105", "S106", "S107",  # todo: Possible hardcoded password: ...
     "S113",  # todo: Probable use of requests call without timeout
@@ -103,12 +105,14 @@ ignore-init-module-imports = true
     "RET503",
 ]
 "tests/**" = [
+    "F841",  # Local variable is assigned to but never used
     "S101",  # Use of `assert` detected
     "S105", "S106",  # todo: Possible hardcoded password: ...
     "S301",  # `pickle` and modules that wrap it can be unsafe when used to deserialize untrusted data, possible security issue
     "S113",  # todo: Probable use of requests call without timeout
     "S311",  # todo: Standard pseudo-random generators are not suitable for cryptographic purposes
     "S108",  # todo: Probable insecure usage of temporary file or directory: "/tmp/sys-customizations-sync"
+    "S202",  # Uses of `tarfile.extractall()`
     "S403",  # `pickle`, `cPickle`, `dill`, and `shelve` modules are possibly insecure
     "S404",  # `subprocess` module is possibly insecure
     "S602",  # todo: `subprocess` call with `shell=True` identified, security issue

src/lightning/app/CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 
+## [2.1.4] - 2024-01-31
+
+### Changed
+
+- Remove torch distributed for the Dataset Optimizer ([#19182](https://github.com/Lightning-AI/lightning/pull/19182))
+
+
 ## [2.1.3] - 2023-12-21
 
 ### Changed

src/lightning/app/cli/cmd_pl_init.py

@@ -121,7 +121,7 @@ def download_frontend(destination: Path) -> None:
     with TemporaryDirectory() as download_dir:
         response = urllib.request.urlopen(url)  # noqa: S310
         file = tarfile.open(fileobj=response, mode="r|gz")
-        file.extractall(path=download_dir)
+        file.extractall(path=download_dir)  # noqa: S202
         shutil.move(str(Path(download_dir, build_dir_name)), destination)
 
 

src/lightning/app/plugin/plugin.py

@@ -154,7 +154,7 @@ def _run_plugin(run: _Run) -> Dict[str, Any]:
             logger.info("Extracting plugin source.")
 
             with tarfile.open(download_path, "r:gz") as tf:
-                tf.extractall(source_path)
+                tf.extractall(source_path)  # noqa: S202
         except Exception as ex:
             raise HTTPException(
                 status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,

src/lightning/app/storage/drive.py

@@ -334,7 +334,7 @@ def __str__(self) -> str:
 
 
 def _maybe_create_drive(component_name: str, state: Dict) -> Union[Dict, Drive]:
-    if state.get("type", None) == Drive.__IDENTIFIER__:
+    if state.get("type") == Drive.__IDENTIFIER__:
         drive = Drive.from_dict(state)
         drive.component_name = component_name
         return drive

src/lightning/app/utilities/packaging/cloud_compute.py

@@ -156,7 +156,7 @@ def from_dict(cls, d: dict) -> "CloudCompute":
                 f"mounts argument must be one of [None, Mount, List[Mount]], "
                 f"received {mounts} of type {type(mounts)}"
             )
-        _verify_mount_root_dirs_are_unique(d.get("mounts", None))
+        _verify_mount_root_dirs_are_unique(d.get("mounts"))
         return cls(**d)
 
     @property
@@ -183,6 +183,6 @@ def _verify_mount_root_dirs_are_unique(mounts: Union[None, Mount, List[Mount], T
 
 
 def _maybe_create_cloud_compute(state: Dict) -> Union[CloudCompute, Dict]:
-    if state and state.get("type", None) == __CLOUD_COMPUTE_IDENTIFIER__:
+    if state and state.get("type") == __CLOUD_COMPUTE_IDENTIFIER__:
         return CloudCompute.from_dict(state)
     return state

src/lightning/app/utilities/packaging/lightning_utils.py

@@ -52,7 +52,7 @@ def download_frontend(root: str = _PROJECT_ROOT):
     response = urllib.request.urlopen(LIGHTNING_FRONTEND_RELEASE_URL)  # noqa: S310
 
     file = tarfile.open(fileobj=response, mode="r|gz")
-    file.extractall(path=download_dir)
+    file.extractall(path=download_dir)  # noqa: S202
 
     shutil.move(os.path.join(download_dir, build_dir), frontend_dir)
     print("The Lightning UI has successfully been downloaded!")