Skip to content

Commit 8639fe7

Browse files
committed
remove todo
1 parent bd382bd commit 8639fe7

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

tests/tests_pytorch/loggers/test_all.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ def log_metrics(self, metrics, step):
107107

108108
if logger_class == CometLogger:
109109
logger.experiment.id = "foo"
110-
# TODO: Verify with @justusschock if this is accepted approach to test experiment creation
111110
logger.logger_impl._comet_config.offline_directory = None
112111
logger.logger_impl._project_name = "bar"
113112
logger.experiment.get_key.return_value = "SOME_KEY"
@@ -359,7 +358,6 @@ def test_logger_default_name(mlflow_mock, monkeypatch, tmp_path):
359358
logger = _instantiate_logger(MLFlowLogger, save_dir=tmp_path)
360359

361360
_ = logger.experiment
362-
# TODO: Verify with @justusschock if this is accepted approach to test experiment creation
363361
logger.logger_impl._mlflow_client.create_experiment.assert_called_with(name="lightning_logs", artifact_location=ANY)
364362
# on MLFLowLogger `name` refers to the experiment id
365363
# assert logger.experiment.get_experiment(logger.name).name == "lightning_logs"

0 commit comments

Comments
 (0)