Fixed WandbLogger save_dir is not set after creation (#12748) (#14326)

Co-authored-by: Jirka Borovec <[email protected]>

Author: 2 people

src/pytorch_lightning/loggers/wandb.py

@@ -223,7 +223,7 @@ def __init__(self, *args, **kwarg):
 
     Args:
         name: Display name for the run.
-        save_dir: Path where data is saved (wandb dir by default).
+        save_dir: Path where data is saved.
         offline: Run offline (data can be streamed later to wandb servers).
         id: Sets the version, mainly used to resume a previous run.
         version: Same as id.
@@ -255,7 +255,7 @@ def __init__(self, *args, **kwarg):
     def __init__(
         self,
         name: Optional[str] = None,
-        save_dir: Optional[str] = None,
+        save_dir: str = ".",
         offline: bool = False,
         id: Optional[str] = None,
         anonymous: Optional[bool] = None,
@@ -300,7 +300,7 @@ def __init__(
             name=name,
             project=project,
             id=version or id,
-            dir=save_dir,
+            dir=save_dir or kwargs.pop("dir"),
             resume="allow",
             anonymous=("allow" if anonymous else None),
         )

tests/tests_pytorch/loggers/test_wandb.py

@@ -58,9 +58,15 @@ def test_wandb_logger_init(wandb, monkeypatch):
     wandb.init.reset_mock()
     WandbLogger(project="test_project").experiment
     wandb.init.assert_called_once_with(
-        name=None, dir=None, id=None, project="test_project", resume="allow", anonymous=None
+        name=None, dir=".", id=None, project="test_project", resume="allow", anonymous=None
     )
 
+    # test wandb.init set save_dir correctly after created
+    wandb.run = None
+    wandb.init.reset_mock()
+    logger = WandbLogger(project="test_project")
+    assert logger.save_dir is not None
+
     # test wandb.init and setting logger experiment externally
     wandb.run = None
     run = wandb.init()