Skip to content

Commit 8fba466

Browse files
author
Ali Alshaarawy
committed
exclude macos from bnb upgrade
1 parent 17273b4 commit 8fba466

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

requirements/fabric/strategies.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@
66
# note: is a bug around 0.10 with `MPS_Accelerator must implement all abstract methods`
77
# shall be resolved by https://github.com/microsoft/DeepSpeed/issues/4372
88
deepspeed >=0.8.2, <=0.9.3; platform_system != "Windows" and platform_system != "Darwin" # strict
9-
bitsandbytes >=0.44.0,<0.44.2
9+
bitsandbytes >=0.44.0,<0.44.2; sys_platform == 'linux' or sys_platform == 'win32'
10+
bitsandbytes >=0.42.0,<0.43.0 ; sys_platform == 'darwin'

requirements/pytorch/extra.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,5 @@ hydra-core >=1.2.0, <1.4.0
88
jsonargparse[signatures] >=4.27.7, <4.28.0
99
rich >=12.3.0, <13.6.0
1010
tensorboardX >=2.2, <2.7.0 # min version is set by torch.onnx missing attribute
11-
bitsandbytes >=0.44.0,<0.44.2
11+
bitsandbytes >=0.44.0,<0.44.2; sys_platform == 'linux' or sys_platform == 'win32'
12+
bitsandbytes >=0.42.0,<0.43.0 ; sys_platform == 'darwin'

src/lightning/fabric/plugins/precision/bitsandbytes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
log = logging.getLogger(__name__)
4141

42-
_BITSANDBYTES_AVAILABLE = RequirementCache("bitsandbytes>=0.44.0")
42+
_BITSANDBYTES_AVAILABLE = RequirementCache("bitsandbytes>=0.42.0")
4343

4444

4545
class BitsandbytesPrecision(Precision):

0 commit comments

Comments
 (0)