Skip to content

Commit 91003c9

Browse files
akihironittalexierule
authored andcommitted
Pin protobuf version (#13177)
1 parent 11bdd6e commit 91003c9

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

pytorch_lightning/setup_tools.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@ def _load_requirements(
3232
reqs = []
3333
for ln in lines:
3434
# filer all comments
35+
comment = ""
3536
if comment_char in ln:
37+
comment = ln[ln.index(comment_char) :]
3638
ln = ln[: ln.index(comment_char)]
37-
comment = ln[ln.index(comment_char) :] if comment_char in ln else ""
3839
req = ln.strip()
3940
# skip directly installed dependencies
4041
if not req or req.startswith("http") or "@http" in req:

requirements/base.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@ torchmetrics>=0.4.1, <=0.7.2
88
pyDeprecate>=0.3.1, <=0.3.2
99
packaging>=17.0, <=21.3
1010
typing-extensions>=4.0.0, <4.2.1
11+
protobuf<=3.20.1 # strict. TODO: Remove after tensorboard gets compatible https://github.com/tensorflow/tensorboard/issues/5708

0 commit comments

Comments
 (0)