Fix param_groups typo

awaelchli · lantiga · commit 97e2d4ddc53b · 2023-07-10T17:06:44.000+02:00
diff --git a/src/lightning/fabric/strategies/fsdp.py b/src/lightning/fabric/strategies/fsdp.py
@@ -353,7 +353,7 @@ def _optimizer_has_flat_params(optimizer: Optimizer) -> bool:
     _FSDP_FLATTENED = "_fsdp_flattened"
     if _TORCH_GREATER_EQUAL_1_13:
         return any(
-            getattr(param, _FSDP_FLATTENED, False) for group in optimizer.param_group for param in group["params"]
+            getattr(param, _FSDP_FLATTENED, False) for group in optimizer.param_groups for param in group["params"]
         )
 
     from torch.distributed.fsdp import FlatParameter

Original file line number	Diff line number	Diff line change
`@@ -353,7 +353,7 @@ def _optimizer_has_flat_params(optimizer: Optimizer) -> bool:`
`353`	`353`	`_FSDP_FLATTENED = "_fsdp_flattened"`
`354`	`354`	`if _TORCH_GREATER_EQUAL_1_13:`
`355`	`355`	`return any(`
`356`		`- getattr(param, _FSDP_FLATTENED, False) for group in optimizer.param_group for param in group["params"]`
	`356`	`+ getattr(param, _FSDP_FLATTENED, False) for group in optimizer.param_groups for param in group["params"]`
`357`	`357`	`)`
`358`	`358`
`359`	`359`	`from torch.distributed.fsdp import FlatParameter`