42
42
)
43
43
from lightning .pytorch .demos .boring_classes import BoringDataModule , BoringModel
44
44
from lightning .pytorch .loggers import CSVLogger , TensorBoardLogger
45
- from lightning .pytorch .loggers .comet import _COMET_AVAILABLE
46
- from lightning .pytorch .loggers .neptune import _NEPTUNE_AVAILABLE
47
- from lightning .pytorch .loggers .wandb import _WANDB_AVAILABLE
48
45
from lightning .pytorch .strategies import DDPStrategy
49
46
from lightning .pytorch .trainer .states import TrainerFn
50
47
from lightning .pytorch .utilities .exceptions import MisconfigurationException
@@ -1433,7 +1430,7 @@ def test_cli_logger_shorthand():
1433
1430
assert cli .trainer .logger is None
1434
1431
1435
1432
1436
- def _test_logger_init_args (logger_name , init , unresolved = {} ):
1433
+ def _test_logger_init_args (logger_name , init , unresolved = None ):
1437
1434
cli_args = [f"--trainer.logger={ logger_name } " ]
1438
1435
cli_args += [f"--trainer.logger.{ k } ={ v } " for k , v in init .items ()]
1439
1436
cli_args += [f"--trainer.logger.dict_kwargs.{ k } ={ v } " for k , v in unresolved .items ()]
@@ -1449,50 +1446,37 @@ def _test_logger_init_args(logger_name, init, unresolved={}):
1449
1446
assert data ["dict_kwargs" ] == unresolved
1450
1447
1451
1448
1452
- @pytest .mark .skipif (not _COMET_AVAILABLE , reason = "comet-ml is required" )
1453
1449
def test_comet_logger_init_args ():
1454
1450
_test_logger_init_args (
1455
1451
"CometLogger" ,
1456
- {
1457
- "save_dir" : "comet" , # Resolve from CometLogger.__init__
1458
- "workspace" : "comet" , # Resolve from Comet{,Existing,Offline}Experiment.__init__
1459
- },
1452
+ init = {"save_dir" : "comet" }, # Resolve from CometLogger.__init__
1453
+ unresolved = {"workspace" : "comet" }, # Resolve from Comet{,Existing,Offline}Experiment.__init__
1460
1454
)
1461
1455
1462
1456
1463
- @pytest .mark .skipif (not _NEPTUNE_AVAILABLE , reason = "neptune is required" )
1464
1457
def test_neptune_logger_init_args ():
1465
1458
_test_logger_init_args (
1466
1459
"NeptuneLogger" ,
1467
- {
1468
- "name" : "neptune" , # Resolve from NeptuneLogger.__init__
1469
- },
1470
- {
1471
- "description" : "neptune" , # Unsupported resolving from neptune.internal.init.run.init_run
1472
- },
1460
+ init = {"name" : "neptune" }, # Resolve from NeptuneLogger.__init__
1461
+ unresolved = {"description" : "neptune" }, # Unsupported resolving from neptune.internal.init.run.init_run
1473
1462
)
1474
1463
1475
1464
1476
1465
def test_tensorboard_logger_init_args ():
1477
1466
_test_logger_init_args (
1478
1467
"TensorBoardLogger" ,
1479
- {
1468
+ init = {
1480
1469
"save_dir" : "tb" , # Resolve from TensorBoardLogger.__init__
1481
1470
},
1482
- {
1483
- "comment" : "tb" , # Unsupported resolving from local imports
1484
- },
1471
+ unresolved = {},
1485
1472
)
1486
1473
1487
1474
1488
- @pytest .mark .skipif (not _WANDB_AVAILABLE , reason = "wandb is required" )
1489
1475
def test_wandb_logger_init_args ():
1490
1476
_test_logger_init_args (
1491
1477
"WandbLogger" ,
1492
- {
1493
- "save_dir" : "wandb" , # Resolve from WandbLogger.__init__
1494
- "notes" : "wandb" , # Resolve from wandb.sdk.wandb_init.init
1495
- },
1478
+ init = {"save_dir" : "wandb" }, # Resolve from WandbLogger.__init__
1479
+ unresolved = {"notes" : "wandb" }, # Resolve from wandb.sdk.wandb_init.init
1496
1480
)
1497
1481
1498
1482
0 commit comments