Skip to content

Commit 99454ec

Browse files
committed
remove unloved type ignore and print some more on exit
1 parent 6068267 commit 99454ec

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/lightning/pytorch/core/module.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,7 @@ def log(
531531
logger=logger,
532532
on_step=on_step,
533533
on_epoch=on_epoch,
534-
reduce_fx=reduce_fx, # type: ignore[arg-type]
534+
reduce_fx=reduce_fx,
535535
enable_graph=enable_graph,
536536
add_dataloader_idx=add_dataloader_idx,
537537
batch_size=batch_size,

tests/run_standalone_tests.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ function show_batched_output {
4848
# heuristic: stop if there's mentions of errors. this can prevent false negatives when only some of the ranks fail
4949
if perl -nle 'print if /error|(?<!(?-i)on_)exception|traceback|(?<!(?-i)x)failed/i' standalone_test_output.txt | grep -qv -f testnames.txt; then
5050
echo "Potential error! Stopping."
51+
perl -nle 'print if /error|(?<!(?-i)on_)exception|traceback|(?<!(?-i)x)failed/i' standalone_test_output.txt
5152
rm standalone_test_output.txt
5253
exit 1
5354
fi

0 commit comments

Comments
 (0)