Skip to content

Commit 9d25e9a

Browse files
authored
Handle more of the flaky tests (#19193)
handle more of the flaky tests
1 parent 002a465 commit 9d25e9a

File tree

4 files changed

+5
-0
lines changed

4 files changed

+5
-0
lines changed

tests/tests_fabric/utilities/test_distributed.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ def test_collective_operations(devices, process):
118118
spawn_launch(process, devices)
119119

120120

121+
@pytest.mark.flaky(reruns=3) # flaky with "process 0 terminated with signal SIGABRT" (GLOO)
121122
def test_is_shared_filesystem(tmp_path, monkeypatch):
122123
# In the non-distributed case, every location is interpreted as 'shared'
123124
assert is_shared_filesystem(SingleDeviceStrategy(torch.device("cpu")))

tests/tests_fabric/utilities/test_spike.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ def spike_detection_test(fabric, global_rank_spike, spike_value, should_raise):
2828
)
2929

3030

31+
@pytest.mark.flaky(max_runs=3)
3132
@pytest.mark.parametrize(
3233
("global_rank_spike", "num_devices", "spike_value", "finite_only"),
3334
[

tests/tests_pytorch/callbacks/test_spike.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ def on_train_batch_end(self, trainer, pl_module, outputs, batch, batch_idx):
4646
super().on_train_batch_end(trainer, pl_module, outputs, batch, batch_idx)
4747

4848

49+
@pytest.mark.flaky(max_runs=3)
4950
@pytest.mark.parametrize(
5051
("global_rank_spike", "num_devices", "spike_value", "finite_only"),
5152
[

tests/tests_pytorch/models/test_hparams.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -667,6 +667,8 @@ def test_init_arg_with_runtime_change(tmpdir, cls):
667667
limit_test_batches=2,
668668
max_epochs=1,
669669
logger=TensorBoardLogger(tmpdir),
670+
enable_progress_bar=False,
671+
enable_checkpointing=False,
670672
)
671673
trainer.fit(model)
672674

0 commit comments

Comments
 (0)