update

deependujha · deependujha · commit 9d9ba1897461 · 2025-10-15T12:36:58.000+05:30
diff --git a/src/lightning/pytorch/tuner/batch_size_scaling.py b/src/lightning/pytorch/tuner/batch_size_scaling.py
@@ -315,7 +315,7 @@ def _run_binsearch_scaling(
                 f"Applying margin of {margin:.1%}, reducing batch size from {new_size} to {margin_reduced_size}"
             )
             new_size = margin_reduced_size
-            # update attribute in the model/datamodule as well
+            # propagate the reduced batch size to the model/datamodule attribute
             lightning_setattr(trainer.lightning_module, batch_arg_name, new_size)
 
     return new_size

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ def _run_binsearch_scaling(`
`315`	`315`	`f"Applying margin of {margin:.1%}, reducing batch size from {new_size} to {margin_reduced_size}"`
`316`	`316`	`)`
`317`	`317`	`new_size = margin_reduced_size`
`318`		`- # update attribute in the model/datamodule as well`
	`318`	`+ # propagate the reduced batch size to the model/datamodule attribute`
`319`	`319`	`lightning_setattr(trainer.lightning_module, batch_arg_name, new_size)`
`320`	`320`
`321`	`321`	`return new_size`