Skip to content

Commit 9f5e604

Browse files
authored
Merge branch 'master' into feat/dynamo_export_onnx
2 parents 019125d + fafc239 commit 9f5e604

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+353
-139
lines changed

.github/ISSUE_TEMPLATE/1_bug_report.yaml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,22 @@ body:
4646
attributes:
4747
value: "**Note: The rest of this form is optional, but filling it out may help us to provide better support.**"
4848

49+
- type: input
50+
attributes:
51+
label: Reproduced in studio
52+
description: >
53+
Create a new Lightning Studio with code that reproduces the issue and share the link.
54+
Also include all the relevant files and data required to reproduce shared issue.
55+
In case the code does not crash, please add assert statements to show what is the real and expected output.
56+
A simple guide on how to create such a studio can be found [here](https://www.youtube.com/watch?v=YcW-2Zt_bFg&ab_channel=LightningAI).
57+
placeholder: https://lightning.ai/live-session/...
58+
validations:
59+
required: false
4960
- type: textarea
5061
attributes:
5162
label: How to reproduce the bug
5263
description: >
53-
Provide steps and example code here.
54-
You can also paste a link to Google Colab (see our [Colab bug report template](https://colab.research.google.com/github/Lightning-AI/lightning/blob/master/examples/pytorch/bug_report/bug_report_model.ipynb)) or adapt this minimal [snippet](https://github.com/Lightning-AI/lightning/blob/master/examples/pytorch/bug_report/bug_report_model.py).
64+
In the special case when the issue can't be reproduced in a studio, provide steps and example code here.
5565
placeholder: |
5666
```python
5767
# Sample code to reproduce the problem

.github/dependabot.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ updates:
1919
separator: "-"
2020
# Allow up to 5 open pull requests for pip dependencies
2121
open-pull-requests-limit: 10
22-
reviewers:
23-
- "Lightning-AI/teams/core-lightning"
2422

2523
# Enable version updates for GitHub Actions
2624
- package-ecosystem: "github-actions"
@@ -37,5 +35,3 @@ updates:
3735
separator: "-"
3836
# Allow up to 5 open pull requests for GitHub Actions
3937
open-pull-requests-limit: 10
40-
reviewers:
41-
- "Lightning-AI/teams/core-lightning"

.github/workflows/_legacy-checkpoints.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ jobs:
113113

114114
- run: pip install -r requirements/ci.txt
115115
- name: Upload checkpoints to S3
116-
if: secrets.AWS_REGION != ''
116+
if: ${{ secrets[AWS_REGION] != '' }}
117117
working-directory: ${{ env.LEGACY_FOLDER }}
118118
env:
119119
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY }}
File renamed without changes.

.github/workflows/docker-build.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,11 @@ jobs:
9494
strategy:
9595
fail-fast: false
9696
matrix:
97+
# adding dome more images as Thunder mainly using python 3.10,
98+
# and we need to support integrations as for example LitGPT
99+
python_version: ["3.10"]
100+
pytorch_version: ["2.6.0", "2.7.0"]
101+
cuda_version: ["12.6.3"]
97102
include:
98103
# These are the base images for PL release docker images.
99104
# Make sure the matrix here matches the one above.

.github/workflows/release-pkg.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ on:
1313
- "requirements/ci.txt"
1414
- ".github/actions/pkg-check/*"
1515
- ".github/actions/pkg-publish/*"
16-
- ".github/workflows/_legacy-checkpoints.yml.yml"
16+
- ".github/workflows/_legacy-checkpoints.yml"
1717
- ".github/workflows/_build-packages.yml"
1818
- ".github/workflows/release-pypi.yml"
1919

@@ -179,12 +179,12 @@ jobs:
179179
with:
180180
pkg-folder: dist/${{ steps.folder.outputs.pkg }}
181181
pypi-token: ${{ secrets[format('PYPI_TOKEN_{0}', matrix.name)] }}
182-
183-
legacy-checkpoints:
184-
needs: [build-packages]
185-
uses: ./.github/workflows/_legacy-checkpoints.yml
186-
with:
187-
push_to_s3: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
188-
upload_local: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
189-
create_pr: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
190-
secrets: inherit
182+
# FIXME: this is not working suddenly, Unrecognized named-value: 'secrets'
183+
# legacy-checkpoints:
184+
# needs: [build-packages]
185+
# uses: ./.github/workflows/_legacy-checkpoints.yml
186+
# with:
187+
# push_to_s3: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
188+
# upload_local: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
189+
# create_pr: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
190+
# secrets: inherit

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ node_modules/
198198
**/events.out.tfevents.*
199199
examples/**/*.png
200200

201-
# instalation artifacts
201+
# installation artifacts
202202
requirements/base.txt
203203

204204
# CI

_notebooks

docs/source-fabric/advanced/model_parallel/tp_fsdp.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ Next steps
276276

277277
.. displayitem::
278278
:header: Pipeline Parallelism
279-
:description: Coming sooon
279+
:description: Coming soon
280280
:col_css: col-md-4
281281
:height: 160
282282
:tag: advanced

docs/source-pytorch/advanced/compile.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ Avoid graph breaks
262262
When ``torch.compile`` looks at the code in your model's ``forward()`` or ``*_step()`` method, it will try to compile as much of the code as possible.
263263
If there are regions in the code that it doesn't understand, it will introduce a so-called "graph break" that essentially splits the code in optimized and unoptimized parts.
264264
Graph breaks aren't a deal breaker, since the optimized parts should still run faster.
265-
But if you want to get the most out of ``torch.compile``, you might want to invest rewriting the problematic section of the code that produce the breaks.
265+
But if you want to get the most out of ``torch.compile``, you might want to invest rewriting the problematic section of the code that produces the breaks.
266266

267267
You can check whether your model produces graph breaks by calling ``torch.compile`` with ``fullgraph=True``:
268268

@@ -332,7 +332,7 @@ Enabling CUDA Graphs often results in a significant speedup, but sometimes also
332332
333333
**Shape padding:** The specific shape/size of the tensors involved in the computation of your model (input, activations, weights, gradients, etc.) can have an impact on the performance.
334334
With shape padding enabled, ``torch.compile`` can extend the tensors by padding to a size that gives a better memory alignment.
335-
Naturally, the tradoff here is that it will consume a bit more memory.
335+
Naturally, the tradeoff here is that it will consume a bit more memory.
336336

337337
.. code-block:: python
338338

0 commit comments

Comments
 (0)