Skip to content

Commit be0ae06

Browse files
authored
Add ddp_find_unused_parameters_true alias in Fabric's DDPStrategy (#20125)
1 parent 2129fdf commit be0ae06

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

src/lightning/fabric/strategies/ddp.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,13 @@ def register_strategies(cls, strategy_registry: _StrategyRegistry) -> None:
200200
description=f"DDP strategy with `start_method={start_method!r}`",
201201
start_method=start_method,
202202
)
203+
strategy_registry.register(
204+
"ddp_find_unused_parameters_true",
205+
cls,
206+
description="Alias for `find_unused_parameters_true` and `start_method='popen'`",
207+
find_unused_parameters=True,
208+
start_method="popen",
209+
)
203210

204211
def _setup_distributed(self) -> None:
205212
self._set_world_ranks()

tests/tests_fabric/strategies/test_registry.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ def __init__(self, param1, param2):
4242
def test_available_strategies_in_registry():
4343
expected = {
4444
"ddp",
45+
"ddp_find_unused_parameters_true",
4546
"deepspeed",
4647
"deepspeed_stage_1",
4748
"deepspeed_stage_1_offload",

tests/tests_fabric/test_cli.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,9 @@ def test_run_env_vars_strategy(_, strategy, monkeypatch, fake_script):
7171
def test_run_get_supported_strategies():
7272
"""Test to ensure that when new strategies get added, we must consider updating the list of supported ones in the
7373
CLI."""
74-
assert len(_get_supported_strategies()) == 7
74+
assert len(_get_supported_strategies()) == 8
7575
assert "fsdp" in _get_supported_strategies()
76+
assert "ddp_find_unused_parameters_true" in _get_supported_strategies()
7677

7778

7879
@pytest.mark.parametrize("strategy", ["ddp_spawn", "ddp_fork", "ddp_notebook", "deepspeed_stage_3_offload"])

0 commit comments

Comments
 (0)