fix package and validate folders (#16299)

Author: Borda

.github/actions/pkg-check/action.yml

@@ -39,13 +39,11 @@ runs:
     shell: bash
 
   - name: Unzip packages
-    if: ${{ inputs.pkg-name != 'lightning' && inputs.pkg-name != 'notset' }}
     working-directory: dist
     run: for file in `ls *.gz`; do tar -xzf $file; done
     shell: bash
 
   - name: Check single pkg/folder
-    if: ${{ inputs.pkg-name != 'lightning' && inputs.pkg-name != 'notset' }}
     working-directory: dist
     run: |
       import os, glob, pathlib, shutil

.github/workflows/docs-checks.yml

@@ -68,7 +68,7 @@ jobs:
 
       - name: Install dependencies
         run: |
-          sudo apt-get update
+          sudo apt-get update --fix-missing
           sudo apt-get install -y cmake pandoc
           pip --version
 
@@ -145,7 +145,7 @@ jobs:
           PACKAGE_NAME: ${{ matrix.pkg-name }}
           FREEZE_REQUIREMENTS: 1
         run: |
-          sudo apt-get update
+          sudo apt-get update --fix-missing
           sudo apt-get install -y cmake pandoc texlive-latex-extra dvipng texlive-pictures
           pip --version
           pip install -e . -U -r requirements/${{ matrix.pkg-name }}/docs.txt \

setup.py

@@ -97,7 +97,9 @@ def _set_manifest_path(manifest_dir: str, aggregate: bool = False) -> Generator:
                     lines.extend(fh.readlines())
         # convert lightning_foo to lightning/foo
         for new, old in mapping.items():
-            lines += [ln.replace(old, f"lightning/{new}") for ln in lines]
+            if old == "lightning":
+                continue  # avoid `lightning` -> `lightning/lightning`
+            lines = [ln.replace(old, f"lightning/{new}") for ln in lines]
         lines = sorted(set(filter(lambda ln: not ln.strip().startswith("#"), lines)))
         with open(manifest_path, mode="w") as fp:
             fp.writelines(lines)

src/lightning_app/MANIFEST.in

@@ -7,4 +7,4 @@ include .actions/assistant.py
 recursive-include src/lightning_app/cli/*-template *
 # TODO: remove this once lightning-ui package is ready as a dependency
 recursive-include src/lightning_app/ui *
-include src/lightning/app/components/serve/catimage.png
+include src/lightning_app/components/serve/catimage.png