add name

Author: justusschock

src/lightning/fabric/accelerators/accelerator.py

@@ -56,6 +56,11 @@ def auto_device_count() -> int:
     def is_available() -> bool:
         """Detect if the hardware is available."""
 
+    @staticmethod
+    @abstractmethod
+    def name() -> str:
+        """The name of the accelerator."""
+
     @classmethod
     def register_accelerators(cls, accelerator_registry: _AcceleratorRegistry) -> None:
-        pass
+        accelerator_registry.register(cls.name(), cls, description=cls.__name__)

src/lightning/fabric/accelerators/cpu.py

@@ -62,14 +62,10 @@ def is_available() -> bool:
         """CPU is always available for execution."""
         return True
 
-    @classmethod
+    @staticmethod
     @override
-    def register_accelerators(cls, accelerator_registry: _AcceleratorRegistry) -> None:
-        accelerator_registry.register(
-            "cpu",
-            cls,
-            description=cls.__name__,
-        )
+    def name() -> str:
+        return "cpu"
 
 
 def _parse_cpu_cores(cpu_cores: Union[int, str]) -> int:

src/lightning/fabric/accelerators/cuda.py

@@ -66,14 +66,10 @@ def auto_device_count() -> int:
     def is_available() -> bool:
         return num_cuda_devices() > 0
 
-    @classmethod
+    @staticmethod
     @override
-    def register_accelerators(cls, accelerator_registry: _AcceleratorRegistry) -> None:
-        accelerator_registry.register(
-            "cuda",
-            cls,
-            description=cls.__name__,
-        )
+    def name() -> str:
+        return "cuda"
 
 
 def find_usable_cuda_devices(num_devices: int = -1) -> list[int]:

src/lightning/fabric/accelerators/mps.py

@@ -74,14 +74,10 @@ def is_available() -> bool:
         mps_disabled = os.getenv("DISABLE_MPS", "0") == "1"
         return not mps_disabled and torch.backends.mps.is_available() and platform.processor() in ("arm", "arm64")
 
-    @classmethod
+    @staticmethod
     @override
-    def register_accelerators(cls, accelerator_registry: _AcceleratorRegistry) -> None:
-        accelerator_registry.register(
-            "mps",
-            cls,
-            description=cls.__name__,
-        )
+    def name() -> str:
+        return "mps"
 
 
 def _get_all_available_mps_gpus() -> list[int]:

src/lightning/fabric/accelerators/xla.py

@@ -93,10 +93,10 @@ def is_available() -> bool:
             # when `torch_xla` is imported but not used
             return False
 
-    @classmethod
+    @staticmethod
     @override
-    def register_accelerators(cls, accelerator_registry: _AcceleratorRegistry) -> None:
-        accelerator_registry.register("tpu", cls, description=cls.__name__)
+    def name() -> str:
+        return "tpu"
 
 
 # PJRT support requires this minimum version